From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 07C533858D20 for ; Fri, 11 Aug 2023 14:46:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07C533858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-686b879f605so1577937b3a.1 for ; Fri, 11 Aug 2023 07:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691765200; x=1692370000; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=76ynF3zeVeou8UXfWK6YlidM9OyuyVJRWKEjWaMfr5k=; b=j0B2CRhC1EKmQOPxA+hX7Czs3VBmxW26Nu0b3XYJIY5C9FGfKF2F9QapCZ48QL1NSV NRG95yK7lroXEZXEYzS6Fmdx8IOR0/UodrB3eElE9DbEZjChBb8hsMRdzm3NXf/Cu8n/ pqG9N2kFleWkYKCQxmk/WHWE0ahnQZc8OHbWUDc0BUgypF8UXD8qR5Oo5/sRrtUHYhVz bTQvVst2AJtC5WJ16ORiL5bgPxmQ6eCdswGcSmSFM66PZyHTIzqfGSdFgbnOTk4i2XEJ KEdyE8ufOVLdfZQd0rjWji5L4+9R2hihtRCOI2xj9o6TAcMwxEE9hT3SRCNtPygKZHhW qrCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691765200; x=1692370000; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=76ynF3zeVeou8UXfWK6YlidM9OyuyVJRWKEjWaMfr5k=; b=IwWX/P1NfJ33K1PIPMGziU5rNVGsSYAtY851oBRZH3GhZfHnB5qBtleSBB5b2IiCKE LReNGbsQysZiAMxCTejyFPlM1/f5QcYcW5o25Kikve1zCyrfFxnMOOn/bneKpS/PXITs VCi96QUvG1r1VJdYkCwTqwQHZB2Dn6e4bF75B0mdwc8zO+eJ2pw0LpUTwJNUEjMy20E4 BFKaZha7R/dX1Qwc/FkWMSJaNlPhzb6DUzAlNAowz4WlK2DHfNIm1zDFVjTM5E6/L/np 9tSEefZS8zrmt5mTg3kwEngYzO38oVeSxeyWCeNkkVsEe+L7NLmNS2stUTP0f+yptPEm 86EA== X-Gm-Message-State: AOJu0YyhKi+UxA1o+YmTr3FQ5yVRbNeplmOMeP0eMYrsvs1MghfH1QOa QSsYHi2Q+vmjzN8fRZpnhD4= X-Google-Smtp-Source: AGHT+IEmz0tT5S/a/Acq99agO2AuJsHUXMLgDSo8fkoO6ywD+D8fc+KqbYWw7zNK1Yb39gU9S1Q8GA== X-Received: by 2002:a05:6a20:1387:b0:127:76ab:a707 with SMTP id hn7-20020a056a20138700b0012776aba707mr1969935pzc.30.1691765199798; Fri, 11 Aug 2023 07:46:39 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id q23-20020a62ae17000000b0068780736f11sm3509160pff.176.2023.08.11.07.46.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Aug 2023 07:46:39 -0700 (PDT) Message-ID: Date: Fri, 11 Aug 2023 08:46:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] RISC-V: Fix vec_series expander[PR110985] Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, rdapp.gcc@gmail.com References: <20230811084526.237649-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20230811084526.237649-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/11/23 02:45, Juzhe-Zhong wrote: > This patch fix bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110985 > > PR target/110985 > > gcc/ChangeLog: > > * config/riscv/riscv-v.cc (expand_vec_series): Refactor the expander. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/autovec/vls-vlmax/pr110985.c: New test. OK. The wording on the ChangeLog could perhaps be improved -- typically when one says "refactor" there's not supposed to be a functional change. So perhaps "Refactor the expander and don't lose final assignment" or something like that. Also it's generally useful to reviewers to explain the core problem. I can guess from the BZ that we lost an assignment and I can speculate it was a case when the destination wasn't initially a pseudo. The refactoring ensured that the sequence always stores into a pseudo and if that pseudo is not the same as the ultimate target, then we copy from the pseudo to the ultimate target when expansion is done. jeff