From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 3CABE385AC2F for ; Thu, 12 Aug 2021 17:46:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CABE385AC2F Received: by mail-pj1-x102e.google.com with SMTP id w13-20020a17090aea0db029017897a5f7bcso11927904pjy.5 for ; Thu, 12 Aug 2021 10:46:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UI15WtPEP20VpMF01QjiEySyQ3Of1xLjYB4xCGE8F/E=; b=bC3lQaiicehKOnZpYUkV613uAlDbHoLOt4ZtUzZ1mW7MWvGlPDk9U2Fq2dEXae69Xl xK6C1Shbhlof8O7/JSW527AIfSyK0htY62VFeOLUI1V5pBMHfJHruYElZtwKHafPcFnq nEjiCRPAXivfCp6hzFZJdQbVzOl3S7JtL2TuBbnBbZBvUsmkyty4A90zDxRigI92hCwv hqDJ41E9dARDEVBJlHmwy2ZdgMFeLAqd05uWpHMoojvpJTUZRilvdm2VrV1dqnFT7KsW xfPvJC++I3SUdSY2mEOuWNdGiGhaTyofHNRpZFJNVlcYlXYGXWfcLrgRFUfW/hQmCz1o KpBQ== X-Gm-Message-State: AOAM53334ckyCntQv0oKjfQig+FpCCqcmHcmoOgRhbJliqEFvX7eXZRZ 727ORISO8Ir45BdZFIoBQus= X-Google-Smtp-Source: ABdhPJyUCV3dgSCa2DlEvR6Wn5op1mBw8Qf9xwviWxeKNfzX5A6ohaMRildcXNAmNx+KUkq9V3uecw== X-Received: by 2002:a17:90a:cb86:: with SMTP id a6mr17353392pju.137.1628790400139; Thu, 12 Aug 2021 10:46:40 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id y7sm3813502pfi.204.2021.08.12.10.46.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 10:46:39 -0700 (PDT) Subject: Re: [PATCH] Remove legacy back threader. To: Aldy Hernandez , GCC patches References: <20210805094821.3143012-1-aldyh@redhat.com> From: Jeff Law Message-ID: Date: Thu, 12 Aug 2021 11:46:38 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 17:46:43 -0000 On 8/12/2021 8:34 AM, Aldy Hernandez wrote: > PING > > On Thu, Aug 5, 2021 at 11:48 AM Aldy Hernandez wrote: >> At this point I don't see any use for the legacy mode, which I had >> originally left in place during the transition. >> >> This patch removes the legacy back threader, and cleans up the code a >> bit. There are no functional changes to the non-legacy code. >> >> Tested on x86-64 Linux. >> >> OK? >> >> gcc/ChangeLog: >> >> * doc/invoke.texi: Remove docs for threader-mode param. >> * flag-types.h (enum threader_mode): Remove. >> * params.opt: Remove threader-mode param. >> * tree-ssa-threadbackward.c (class back_threader): Remove >> path_is_unreachable_p. >> Make find_paths private. >> Add maybe_thread and thread_through_all_blocks. >> Remove reference marker for m_registry. >> Remove reference marker for m_profit. >> (back_threader::back_threader): Adjust for registry and profit not >> being references. >> (dump_path): Move down. >> (debug): Move down. >> (class thread_jumps): Remove. >> (class back_threader_registry): Remove m_all_paths. >> Remove destructor. >> (thread_jumps::thread_through_all_blocks): Move to back_threader >> class. >> (fsm_find_thread_path): Remove >> (back_threader::maybe_thread): New. >> (back_threader::thread_through_all_blocks): Move from >> thread_jumps. >> (back_threader_registry::back_threader_registry): Remove >> m_all_paths. >> (back_threader_registry::~back_threader_registry): Remove. >> (thread_jumps::find_taken_edge): Remove. >> (thread_jumps::check_subpath_and_update_thread_path): Remove. >> (thread_jumps::maybe_register_path): Remove. >> (thread_jumps::handle_phi): Remove. >> (handle_assignment_p): Remove. >> (thread_jumps::handle_assignment): Remove. >> (thread_jumps::fsm_find_control_statement_thread_paths): Remove. >> (thread_jumps::find_jump_threads_backwards): Remove. >> (thread_jumps::find_jump_threads_backwards_with_ranger): Remove. >> (try_thread_blocks): Rename find_jump_threads_backwards to >> maybe_thread. >> (pass_early_thread_jumps::execute): Same. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.dg/tree-ssa/ssa-dom-thread-7.c: Remove call into the legacy >> code and adjust for ranger threader. SOrry, I thought I'd already pre-approved this :-) OK jeff