Re: [2/5] C-SKY port: Backend implementation

[Jeff Law <law@redhat.com>]

On 07/23/2018 10:21 PM, Sandra Loosemore wrote:
> 2018-07-23  Jojo  <jijie_rong@c-sky.com>
>             Huibin Wang  <huibin_wang@c-sky.com>
>             Sandra Loosemore  <sandra@codesourcery.com>
>             Chung-Lin Tang  <cltang@codesourcery.com>
> 
>         C-SKY port: Backend implementation
> 
>         gcc/
>         * config/csky/*: New.
>         * common/config/csky/*: New.

Let's avoid gratutious whitespace that attempts to line up conditionals.
  As an example, look at the predicate csky_load_multiple_operation.  I
think just doing a quick pass over the .c, .h and main .md files should
be sufficient here.

I'm not a big fan of more awk code, but I'm not going to object to it :-)

Why does the port have its own little pass for condition code
optimization (cse_cc)?  What is it doing that can't be done with our
generic optimizers?

Any thoughts on using the newer function descriptor bits rather than old
style stack trampolines?

I don't see anything terribly concerning in the core of the port.  The
amount of support code for minipool is huge and I wonder if some sharing
across the various ports would be possible, but I don't think that
should be a blocking issue for this port.


Can you update the backends.html web page here appropriately for the
c-sky target?

I'd like to take a closer look, but those are the high level comment's
I've got this morning :-)


Jeff