From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126407 invoked by alias); 24 Jul 2018 15:45:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126279 invoked by uid 89); 24 Jul 2018 15:45:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jul 2018 15:45:41 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D1F68110D; Tue, 24 Jul 2018 15:45:34 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-68.rdu2.redhat.com [10.10.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14C3160BE4; Tue, 24 Jul 2018 15:45:32 +0000 (UTC) Subject: Re: [2/5] C-SKY port: Backend implementation To: Sandra Loosemore , "gcc-patches@gcc.gnu.org" Cc: Han Mao , Yunhai Shang References: <49d0a2c8-51a0-4a74-d015-0bf1c1098e38@codesourcery.com> <28cb3a6e-4594-3545-5236-c68784af6a57@codesourcery.com> From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Tue, 24 Jul 2018 15:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <28cb3a6e-4594-3545-5236-c68784af6a57@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg01403.txt.bz2 On 07/23/2018 10:21 PM, Sandra Loosemore wrote: > 2018-07-23  Jojo  >             Huibin Wang  >             Sandra Loosemore  >             Chung-Lin Tang  > >         C-SKY port: Backend implementation > >         gcc/ >         * config/csky/*: New. >         * common/config/csky/*: New. Let's avoid gratutious whitespace that attempts to line up conditionals. As an example, look at the predicate csky_load_multiple_operation. I think just doing a quick pass over the .c, .h and main .md files should be sufficient here. I'm not a big fan of more awk code, but I'm not going to object to it :-) Why does the port have its own little pass for condition code optimization (cse_cc)? What is it doing that can't be done with our generic optimizers? Any thoughts on using the newer function descriptor bits rather than old style stack trampolines? I don't see anything terribly concerning in the core of the port. The amount of support code for minipool is huge and I wonder if some sharing across the various ports would be possible, but I don't think that should be a blocking issue for this port. Can you update the backends.html web page here appropriately for the c-sky target? I'd like to take a closer look, but those are the high level comment's I've got this morning :-) Jeff