From: Robin Dapp <rdapp.gcc@gmail.com>
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com,
jeffreyalaw@gmail.com
Subject: Re: [PATCH V2] RISC-V: Optimize combine sequence by merge approach
Date: Mon, 13 Nov 2023 11:05:14 +0100 [thread overview]
Message-ID: <baebacea-7061-4cb8-a09f-4f80a9dd866a@gmail.com> (raw)
In-Reply-To: <20231113084158.829807-1-juzhe.zhong@rivai.ai>
Hi Juzhe,
LGTM apart from:
> + int64_t a = -1789089.23423;
> + int64_t b = -8916156.45644;
What's that? :) Doesn't really matter of course but please change to
a proper integer. OK with that changed.
Regards
Robin
next prev parent reply other threads:[~2023-11-13 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 8:41 Juzhe-Zhong
2023-11-13 10:05 ` Robin Dapp [this message]
2023-11-13 10:31 ` juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baebacea-7061-4cb8-a09f-4f80a9dd866a@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).