[PATCH] Fix #error in mips loongson-mmintrin.h

[PATCH] Fix #error in mips loongson-mmintrin.h

[Jakub Jelinek]

Hi!

While doing make gcc.pot, I've noticed warnings about unterminated string
in loongson-mmintrin.h.
I don't have any usable mips setup, but just tried:
/tmp/1a.c:
# error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
	 loongson-mmiintrin.h"
/tmp/1b.c:
# error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use\
 loongson-mmiintrin.h
$ gcc -S -o /tmp/1a.{s,c}
/tmp/1a.c:1:9: warning: missing terminating " character
 # error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
         ^
/tmp/1a.c:1:3: error: #error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
 # error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
   ^~~~~
/tmp/1a.c:2:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘-’ token
   loongson-mmiintrin.h"
           ^
/tmp/1a.c:2:23: warning: missing terminating " character
   loongson-mmiintrin.h"
                       ^
/tmp/1a.c:2:23: error: missing terminating " character
$ gcc -S -o /tmp/1b.{s,c}
/tmp/1b.c:1:3: error: #error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use loongson-mmiintrin.h
 # error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use\
   ^~~~~
and similarly for g++.  Ok for trunk?

2019-04-11  Jakub Jelinek  <jakub@redhat.com>

	* config/mips/loongson-mmiintrin.h: Fix up #error message.

--- gcc/config/mips/loongson-mmiintrin.h.jj	2019-01-01 12:37:22.459887959 +0100
+++ gcc/config/mips/loongson-mmiintrin.h	2019-04-11 14:41:39.901898228 +0200
@@ -28,8 +28,8 @@
 #define _GCC_LOONGSON_MMIINTRIN_H
 
 #if !defined(__mips_loongson_mmi)
-# error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
-	 loongson-mmiintrin.h"
+# error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use\
+ loongson-mmiintrin.h
 #endif
 
 #ifdef __cplusplus

	Jakub

Re: [PATCH] Fix #error in mips loongson-mmintrin.h

[Jeff Law]

On 4/11/19 6:51 AM, Jakub Jelinek wrote:
> Hi!
> 
> While doing make gcc.pot, I've noticed warnings about unterminated string
> in loongson-mmintrin.h.
> I don't have any usable mips setup, but just tried:
> /tmp/1a.c:
> # error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
> 	 loongson-mmiintrin.h"
> /tmp/1b.c:
> # error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use\
>  loongson-mmiintrin.h
> $ gcc -S -o /tmp/1a.{s,c}
> /tmp/1a.c:1:9: warning: missing terminating " character
>  # error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
>          ^
> /tmp/1a.c:1:3: error: #error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
>  # error "You must select -mloongson-mmi or -march=loongson2e/2f/3a to use
>    ^~~~~
> /tmp/1a.c:2:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘-’ token
>    loongson-mmiintrin.h"
>            ^
> /tmp/1a.c:2:23: warning: missing terminating " character
>    loongson-mmiintrin.h"
>                        ^
> /tmp/1a.c:2:23: error: missing terminating " character
> $ gcc -S -o /tmp/1b.{s,c}
> /tmp/1b.c:1:3: error: #error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use loongson-mmiintrin.h
>  # error You must select -mloongson-mmi or -march=loongson2e/2f/3a to use\
>    ^~~~~
> and similarly for g++.  Ok for trunk?
> 
> 2019-04-11  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* config/mips/loongson-mmiintrin.h: Fix up #error message.
OK
jeff
>