From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17553 invoked by alias); 16 Aug 2016 15:42:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17542 invoked by uid 89); 16 Aug 2016 15:42:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tought, threaders, Theresa's, theresa's X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Aug 2016 15:42:00 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CC0561E4C; Tue, 16 Aug 2016 15:41:59 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-13.phx2.redhat.com [10.3.116.13]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7GFfwpB016311; Tue, 16 Aug 2016 11:41:58 -0400 Subject: Re: Early jump threading To: Jan Hubicka References: <20160811140235.GA68714@kam.mff.cuni.cz> <20160816110252.GB26405@kam.mff.cuni.cz> Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de From: Jeff Law Message-ID: Date: Tue, 16 Aug 2016 15:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160816110252.GB26405@kam.mff.cuni.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg01191.txt.bz2 On 08/16/2016 05:02 AM, Jan Hubicka wrote: >> I don't think the backwards/FSM threader tries to update the profile >> data at all right now. > > This seems to be cause of the regression andrew is speaking about. I wrote updating > of profile after threading few times and there was also Theresa's patch. > I tought all the threaders use common duplication engine and that one does the updating? > I will try to dive into the code, but creating basic blocks with frequency 0 across hot > paths is bad idea - they will be optimized for size. No, the updaters are independent. We'll need to port Theresa's work to the newer scheme. jeff