From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100278 invoked by alias); 27 Jun 2018 21:01:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100265 invoked by uid 89); 27 Jun 2018 21:01:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0118.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.118) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 21:01:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevasonline.onmicrosoft.com; s=selector1-prevas-se; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkDjeZADvaev/WlFgx5hG12s+SgHtXqO/6iWvHWVwOE=; b=AQ8phkPlP05WWNaOEotw/Ng6P1VPmJPgYqOp4bGHy3jTrp5hmiLr2rE8jHGYLzKeWhVtrkWkX7AuRU46n0i97xCHdLRYsD5WACeOFAV/CTJcwcOofyUl6tigHI3X/9ekZ1hVzNtLSCDyMUolrm7+g/cJvkfBCzemrCBaywf0aC4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasmus.Villemoes@prevas.se; Received: from [192.168.0.189] (5.186.124.231) by AM4PR1001MB1329.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:200:98::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23; Wed, 27 Jun 2018 21:01:28 +0000 Subject: Re: [PATCH v3] add support for --disable-gcov To: Rainer Orth , Jeff Law Cc: gcc-patches@gcc.gnu.org, Joseph Myers References: <99e19880-9cd6-8895-5e26-21825a8f6021@prevas.dk> <20180611072553.26334-1-rasmus.villemoes@prevas.dk> <5d11f24b-6598-e160-5864-bacc8d8310bd@redhat.com> From: Rasmus Villemoes Message-ID: Date: Wed, 27 Jun 2018 21:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: rasmus.villemoes@prevas.dk Received-SPF: None (protection.outlook.com: prevas.se does not designate permitted sender hosts) X-SW-Source: 2018-06/txt/msg01717.txt.bz2 On 2018-06-27 21:22, Rainer Orth wrote: > Hi Jeff, > >>> So add an option for disabling build and install of libgcov and the >>> related host tools. >>> >>> 2018-06-10 Rasmus Villemoes >>> >>> gcc/ >>> * configure.ac: Add --disable-gcov option. >>> * configure: Regenerate. >>> * Makefile.in: Honour @enable_gcov@. >>> * doc/install.texi: Document --disable-gcov. >>> >>> libgcc/ >>> * configure.ac: Add --disable-gcov option. >>> * configure: Regenerate. >>> * Makefile.in: Honour @enable_gcov@. >> OK. Presumably you're going through the process to get write access. >> Once that's wrapped up you can install this patch. > > this patch badly broke all -fprofile-generate/-fprofile-use tests in the > default case like this: > > UNRESOLVED: g++.dg/bprob/g++-bprob-1.C compilation, -O0 -fbranch-probabilities > FAIL: g++.dg/bprob/g++-bprob-1.C compilation, -O0 -fprofile-arcs > > ld: fatal: library -lgcov: not found > collect2: error: ld returned 1 exit status > compiler exited with status 1 > FAIL: g++.dg/bprob/g++-bprob-1.C compilation, -g -fprofile-arcs > > libgcov.a is not copied over from libgcc to gcc due to a typo in > libgcc/Makefile.in. Fixed as follows; will install as obvious once > bootstrap has finished. > I'm terribly sorry about that! I was sure I had tested all of --enable-gcov, --disable-gcov and none of those, and convinced myself that the default behaviour was unchanged. Thanks for spotting the problem and fixing it. I will try to be much more careful in the future. Rasmus