From: Jeff Law <law@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, testsuite]: Fix g++.dg/torture/pr86763.C link failure for glibc < 2.17
Date: Mon, 06 Aug 2018 15:44:00 -0000 [thread overview]
Message-ID: <bb77060e-4105-08a1-98b4-aabe3844ec78@redhat.com> (raw)
In-Reply-To: <CAFULd4bEpiAjpO9V4RFh9deXqb7a5NPMuimotHmvONdmhjfvYQ@mail.gmail.com>
On 08/06/2018 09:33 AM, Uros Bizjak wrote:
> On Mon, Aug 6, 2018 at 5:23 PM, Jeff Law <law@redhat.com> wrote:
>> On 08/06/2018 09:10 AM, Uros Bizjak wrote:
>>> 2018-08-06 Uros Bizjak <ubizjak@gmail.com>
>>>
>>> * g++.dg/torture/pr86763.C (dg-additional-options): Add -lrt.
>>>
>>> Tested on CentOS 5.10 and Fedora 28.
>>>
>>> OK for mainline?
>> But what about systems without librt? I'm thinking primarily of the
>> embedded *-elf targets.
>
> Perhaps the following patch is better:
>
> --cut here--
> Index: g++.dg/torture/pr86763.C
> ===================================================================
> --- g++.dg/torture/pr86763.C (revision 263317)
> +++ g++.dg/torture/pr86763.C (working copy)
> @@ -1,5 +1,6 @@
> // { dg-do run }
> // { dg-additional-options "-fschedule-insns2 -fstrict-aliasing" }
> +// { dg-additional-options "-lrt" { target *-*-linux-gnu } }
That's be fine with me.
If someone wants the test to be run on solaris or some other target with
librt, they can extend the selector to include the proper target/versions.
Jeff
next prev parent reply other threads:[~2018-08-06 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 15:10 Uros Bizjak
2018-08-06 15:23 ` Jeff Law
2018-08-06 15:33 ` Uros Bizjak
2018-08-06 15:44 ` Jeff Law [this message]
2018-08-06 15:46 ` Uros Bizjak
2018-08-06 15:54 ` Andreas Schwab
2018-08-07 19:55 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb77060e-4105-08a1-98b4-aabe3844ec78@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).