From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx-relay06-hz2.antispameurope.com (mx-relay06-hz2.antispameurope.com [83.246.65.92]) by sourceware.org (Postfix) with ESMTPS id 445973858423 for ; Sat, 2 Oct 2021 18:30:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 445973858423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=net-b.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=net-b.de Received: from s041.wsp.plusnet.de ([195.90.7.81]) by mx-relay06-hz2.antispameurope.com; Sat, 02 Oct 2021 20:29:58 +0200 Received: from [192.168.0.34] (port-92-195-170-74.dynamic.as20676.net [92.195.170.74]) by s041.wsp.plusnet.de (Postfix) with ESMTPSA id 2E7D12C00BB; Sat, 2 Oct 2021 20:29:55 +0200 (CEST) Subject: Re: [Patch] Fortran: Avoid var initialization in interfaces [PR54753] To: Sandra Loosemore , Tobias Burnus , gcc-patches , fortran References: <40ee9c33-3122-54aa-a43b-655bb280b7fc@codesourcery.com> <0131e2d5-be68-d3b1-b90f-6640c358e1ab@codesourcery.com> From: Tobias Burnus Message-ID: Date: Sat, 2 Oct 2021 20:29:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <0131e2d5-be68-d3b1-b90f-6640c358e1ab@codesourcery.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-cloud-security-sender: burnus@net-b.de X-cloud-security-recipient: gcc-patches@gcc.gnu.org X-cloud-security-Virusscan: CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay06-hz2.antispameurope.com with B01A254011B X-cloud-security-connect: s041.wsp.plusnet.de[195.90.7.81], TLS=1, IP=195.90.7.81 X-cloud-security-Digest: 155823038626db1bcd4a9536df2c24af X-cloud-security: scantime:1.445 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Oct 2021 18:30:05 -0000 On 02.10.21 20:01, Sandra Loosemore wrote: > On 9/29/21 2:53 AM, Tobias Burnus wrote: >> There are three issues, this patch solves the first: >> * reject-valid issue due to adding the initializer also to a dummy >>    argument which is in an INTERFACE block. Having initializers in >>    INTERFACE blocks is pointless and causes for the attached testcase >>    the bogus error: >>    "Assumed-rank variable y at (1) may only be used as actual argument" >> ... > This has indeed allowed me to make progress on adding the diagnostic, > but I'm seeing some test regressions on x86_64-linux-gnu that are due > to this patch alone: > > FAIL: gfortran.dg/default_initialization_3.f90   -O0  execution test I do not see this error. Can you double check that you indeed use the posted patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-September/580483.html – and nothing else, e.g., an earlier draft? (I still have to commit it; it was approved by Harald, but he also he preferred to have a second view, I decided to wait until tomorrow/Monday before committing it.) Tobias