public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH,DWARF,v2] AIX dwarf2out label fix
Date: Thu, 01 Jun 2017 19:03:00 -0000	[thread overview]
Message-ID: <bb98e3a4-cd62-3733-0844-4235fdd55d88@redhat.com> (raw)
In-Reply-To: <CAGWvnynLjij7d2Led0mhTGcK=cYEfXyRmRy6gx9CG7EX-QA7GA@mail.gmail.com>

On 05/18/2017 06:00 AM, David Edelsohn wrote:
> This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on
> DWARF_OFFSET_SIZE to define the string expression to append to the
> label to correct the offset.
> 
> Because AIX Assembler inserts the section length, the section label
> generated by GCC points to the wrong location and must be adjusted
> when referenced in DW_AT_stmt_list.
> 
> +  char dl_section_label[MAX_ARTIFICIAL_LABEL_BYTES];

It seems inaccurate to call this variable "label" when it's a label name 
minus offset.  Maybe dl_section_ref?

>         if (debug_info_level >= DINFO_LEVEL_TERSE)
>           add_AT_lineptr (ctnode->root_die, DW_AT_stmt_list,
>                           (!dwarf_split_debug_info
> -                         ? debug_line_section_label
> +                         ? dl_section_label
>                            : debug_skeleton_line_section_label));

Doesn't debug_skeleton_line_section_label need the same offset?

Jason

  reply	other threads:[~2017-06-01 19:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 10:09 David Edelsohn
2017-06-01 19:03 ` Jason Merrill [this message]
2017-06-01 19:27   ` David Edelsohn
2017-06-01 20:16     ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb98e3a4-cd62-3733-0844-4235fdd55d88@redhat.com \
    --to=jason@redhat.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).