From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13586 invoked by alias); 1 Jun 2017 19:03:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12639 invoked by uid 89); 1 Jun 2017 19:03:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f181.google.com Received: from mail-qk0-f181.google.com (HELO mail-qk0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Jun 2017 19:03:25 +0000 Received: by mail-qk0-f181.google.com with SMTP id d14so44021982qkb.1 for ; Thu, 01 Jun 2017 12:03:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O8CV4KSI5PVNwZk8Xz6juneVnccSOjQ/YtKs48f8YWY=; b=VisXAlCXbDA/7DnQK9ChTeUcyefTzZ7BdqcaYWW9GrFC9f7QWvaC37tf9yJr5ytYUj 9YzKxgv0AcJG24mZr9d08e3416H8VvGeQUZW1OeAGIprxZottWmSufIW2CVrmlEdBzu9 lmneGMi4kXSqZaoHo/+kBWqVr4Hy7nbO4t60vzQyn4tWi4jxtw6dwrqNqfEgGRyqHqwG Endx3cHMFfDaMShQD8a1K1C1YEqqaGxRGbOyY2vnhX8PXzronrxlJkz/yEr7b2Y8nEUE ELm2H2jUfUv0GguW9w24kzNFFXxVKy73TshwhvpzEr1X6AIDJmK9EvxCzJ+6v1ymhGxG CTMA== X-Gm-Message-State: AODbwcC8m36gg0DpU5ULnKxvlexIFCJ5hX2uTx7uVIdNpjvDscMkr9IK Xxk5g38taneJx2xjMR+PPQ== X-Received: by 10.55.215.16 with SMTP id m16mr3569839qki.168.1496343807782; Thu, 01 Jun 2017 12:03:27 -0700 (PDT) Received: from [192.168.1.132] (209-6-90-240.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com. [209.6.90.240]) by smtp.gmail.com with ESMTPSA id d46sm13641503qte.21.2017.06.01.12.03.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2017 12:03:27 -0700 (PDT) Subject: Re: [PATCH,DWARF,v2] AIX dwarf2out label fix To: David Edelsohn , GCC Patches References: From: Jason Merrill Message-ID: Date: Thu, 01 Jun 2017 19:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00075.txt.bz2 On 05/18/2017 06:00 AM, David Edelsohn wrote: > This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on > DWARF_OFFSET_SIZE to define the string expression to append to the > label to correct the offset. > > Because AIX Assembler inserts the section length, the section label > generated by GCC points to the wrong location and must be adjusted > when referenced in DW_AT_stmt_list. > > + char dl_section_label[MAX_ARTIFICIAL_LABEL_BYTES]; It seems inaccurate to call this variable "label" when it's a label name minus offset. Maybe dl_section_ref? > if (debug_info_level >= DINFO_LEVEL_TERSE) > add_AT_lineptr (ctnode->root_die, DW_AT_stmt_list, > (!dwarf_split_debug_info > - ? debug_line_section_label > + ? dl_section_label > : debug_skeleton_line_section_label)); Doesn't debug_skeleton_line_section_label need the same offset? Jason