public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Jørgen Kvalsvik" <j@lambda.is>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Cc: hubicka@ucw.cz
Subject: Re: [PATCH 1/2] Record edge true/false value for gcov
Date: Wed, 26 Jun 2024 12:20:09 +0200	[thread overview]
Message-ID: <bb9e058c-0c44-4fcf-baa8-4213416ada70@lambda.is> (raw)
In-Reply-To: <1450ddcc-a8af-48c4-bd66-b0f20b0c49ce@gmail.com>

On 6/25/24 23:37, Jeff Law wrote:
> 
> 
> On 6/25/24 2:04 AM, Jørgen Kvalsvik wrote:
>> Make gcov aware which edges are the true/false to more accurately
>> reconstruct the CFG.  There are plenty of bits left in arc_info and it
>> opens up for richer reporting.
>>
>> gcc/ChangeLog:
>>
>>     * gcov-io.h (GCOV_ARC_TRUE): New.
>>     (GCOV_ARC_FALSE): New.
>>     * gcov.cc (struct arc_info): Add true_value, false_value.
>>     (read_graph_file): Read true_value, false_value.
>>     * profile.cc (branch_prob): Write GCOV_ARC_TRUE, GCOV_ARC_FALSE.
> I thought I'd already acked this patch.
> 
> So OK, again :-)
> 
> jeff
> 

Thanks! Pushed.

      reply	other threads:[~2024-06-26 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  8:04 Jørgen Kvalsvik
2024-06-25  8:04 ` [PATCH 2/2] [RFC] Prime path coverage in gcc/gcov Jørgen Kvalsvik
2024-06-25 21:37 ` [PATCH 1/2] Record edge true/false value for gcov Jeff Law
2024-06-26 10:20   ` Jørgen Kvalsvik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb9e058c-0c44-4fcf-baa8-4213416ada70@lambda.is \
    --to=j@lambda.is \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=jeffreyalaw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).