* [PATCH] Fix RTL FE issue with premature return
@ 2021-11-29 11:26 Richard Biener
2021-11-29 14:29 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2021-11-29 11:26 UTC (permalink / raw)
To: gcc-patches
This fixes an issue discovered by -Wunreachable-code-return
Bootstrap / regtest pending on x86_64-unknown-linux-gnu, OK?
2021-11-29 Richard Biener <rguenther@suse.de>
* read-rtl-function.c (function_reader::read_rtx_operand):
Return only after resetting m_in_call_function_usage.
---
gcc/read-rtl-function.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/read-rtl-function.c b/gcc/read-rtl-function.c
index 5699f574a37..81d7531ce47 100644
--- a/gcc/read-rtl-function.c
+++ b/gcc/read-rtl-function.c
@@ -886,8 +886,9 @@ function_reader::read_rtx_operand (rtx x, int idx)
if (idx == 7 && CALL_P (x))
{
m_in_call_function_usage = true;
- return rtx_reader::read_rtx_operand (x, idx);
+ rtx tem = rtx_reader::read_rtx_operand (x, idx);
m_in_call_function_usage = false;
+ return tem;
}
else
return rtx_reader::read_rtx_operand (x, idx);
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix RTL FE issue with premature return
2021-11-29 11:26 [PATCH] Fix RTL FE issue with premature return Richard Biener
@ 2021-11-29 14:29 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2021-11-29 14:29 UTC (permalink / raw)
To: Richard Biener, gcc-patches
On 11/29/2021 4:26 AM, Richard Biener via Gcc-patches wrote:
> This fixes an issue discovered by -Wunreachable-code-return
>
> Bootstrap / regtest pending on x86_64-unknown-linux-gnu, OK?
>
> 2021-11-29 Richard Biener <rguenther@suse.de>
>
> * read-rtl-function.c (function_reader::read_rtx_operand):
> Return only after resetting m_in_call_function_usage.
OK.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-29 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 11:26 [PATCH] Fix RTL FE issue with premature return Richard Biener
2021-11-29 14:29 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).