From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 923823858C2A for ; Fri, 7 Jul 2023 14:23:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 923823858C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 367ECkoo013820; Fri, 7 Jul 2023 14:23:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=BsdOiF7/HfsYE7yS/N3VQTVT8rnxpqFBoKeNzCJE+dQ=; b=tc9d6HTkBE1PxJmKBlbu7IXtl+BiXwlBj76P3BRj1j+xT2HZYsnRiltfcLHzrZ5gJp7R 8LCAxELAM3MvMIwKdBRo9Z4I/qezjjSO5dXdm8Gnwy95DBJTe0cw4lnq5U1AGQLUpFOR +fE59kN4qT5JGf82wML/vFxsjVreChOHzw9/QpTahpDRxxX05+1vLH9dq1mSTTYVktWn /8OfuB8+VexKKiHRVPvyyjc2CaHpJvNRGcVJ7vTd5wkGwHX4hpSlnn7oTRBG3jB4WG22 4cl6L1958mO8JDQncHlyIWTPJSl3Py1251lGHsrfNVrVXh2kxogMtT8KSPQn+j11xJJ9 oQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rpm8y0fw4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Jul 2023 14:23:21 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 367EDHDx016777; Fri, 7 Jul 2023 14:23:21 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rpm8y0fvc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Jul 2023 14:23:21 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 367BOr8E014307; Fri, 7 Jul 2023 14:23:20 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([9.208.129.114]) by ppma02wdc.us.ibm.com (PPS) with ESMTPS id 3rjbs6dryc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Jul 2023 14:23:20 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 367ENIaf30802634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Jul 2023 14:23:18 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F11D58043; Fri, 7 Jul 2023 14:23:18 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E31675805D; Fri, 7 Jul 2023 14:23:17 +0000 (GMT) Received: from [9.61.25.68] (unknown [9.61.25.68]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 7 Jul 2023 14:23:17 +0000 (GMT) Message-ID: Date: Fri, 7 Jul 2023 09:23:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH ver 2] rs6000, __builtin_set_fpscr_rn add retrun value Content-Language: en-US To: "Kewen.Lin" , Carl Love Cc: Segher Boessenkool , David Edelsohn , GCC Patches References: <16f31ebb-95a7-5b1a-db9c-51bec864ef07@linux.ibm.com> <10ff14b0-5e33-6006-bc92-4328b4a91bc1@linux.ibm.com> From: Peter Bergner In-Reply-To: <10ff14b0-5e33-6006-bc92-4328b4a91bc1@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 2y9h9fEQs3zAfRAQLMxQ4x9RoP673ajg X-Proofpoint-ORIG-GUID: wKqKwZXS1v0XHBuptXW_f31dEuM9ejG- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-07_10,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 mlxlogscore=784 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307070130 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/7/23 12:08 AM, Kewen.Lin wrote: > on 2023/7/7 07:00, Peter Bergner wrote: >> On 7/6/23 5:54 PM, Peter Bergner wrote: >>> On 6/30/23 7:58 PM, Carl Love via Gcc-patches wrote: >>>> +++ b/gcc/testsuite/gcc.target/powerpc/test_fpscr_rn_builtin_2.c >>>> @@ -0,0 +1,153 @@ >>>> +/* { dg-do run { target { powerpc*-*-* } } } */ >>> >>> powerpc*-*-* is the default for this test directory, so you can drop that, >>> but you need to disable this test for soft-float systems, so you probably want: >>> >>> /* { dg-do run { target powerpc_fprs } } */ >> >> We actually want something like powerpc_fprs_hw, but that doesn't exist. >> > > Yeah, good point! I noticed that we have a few test cases which need to > check soft-float env as well but they don't, I didn't find any related > issues have been reported, so I would assume that there are very few > actual testings on this area. Based on this, I'm not sure if it's worthy > to add a new effective target for it. Personally I'm happy with just using > powerpc_fprs here to keep it simple. :) I think powerpc_fprs_hw can be added later by someone if they care. Using powerpc_fprs is an improvement over powerpc*-*-*, since it will reduce some FAILs, just not all of them a powerpc_fprs_hw would. I doubt many people are running the testsuite on real ppc hardware that doesn't have an FP unit. Peter