From: "Martin Liška" <mliska@suse.cz>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Martin Jambor <mjambor@suse.cz>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] contrib: Put gcc-descr and gcc-undescr to file.
Date: Thu, 27 Jan 2022 18:44:33 +0100 [thread overview]
Message-ID: <bbab42ed-5714-399e-873d-e6b870a20ef1@suse.cz> (raw)
In-Reply-To: <20220127153513.GI2646553@tucnak>
On 1/27/22 16:35, Jakub Jelinek wrote:
> For backwards compatibility, I'd prefer --full to be an alias to --long,
> and maybe the --short handling should short=yes; long=no and
> similarly --long/--full handling should long=yes; short=no
> so that --short --long is --long and --long --short is --short.
I like the suggestions, applied that!
Similarly to Jonathan's comment, thank for it.
I've just pushed that to master.
Martin
>
> Otherwise LGTM.
next prev parent reply other threads:[~2022-01-27 17:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 11:01 [PATCH] contrib: git gcc-descr defaulting to print hash Martin Liška
2021-10-08 11:12 ` Jakub Jelinek
2021-10-11 12:32 ` [RFC] Port git gcc-descr to Python Martin Liška
2021-10-12 8:59 ` Martin Liška
2021-10-14 9:06 ` Tobias Burnus
2021-10-14 9:19 ` Jakub Jelinek
2021-10-18 9:01 ` Martin Liška
2022-01-19 11:01 ` Martin Liška
2022-01-19 12:49 ` Martin Jambor
2022-01-19 13:17 ` Martin Liška
2022-01-19 16:54 ` Eric Gallager
2022-01-27 15:06 ` [PATCH] contrib: Put gcc-descr and gcc-undescr to file Martin Liška
2022-01-27 15:35 ` Jakub Jelinek
2022-01-27 17:44 ` Martin Liška [this message]
2022-01-27 15:51 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbab42ed-5714-399e-873d-e6b870a20ef1@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely.gcc@gmail.com \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).