From: Martin Sebor <msebor@gmail.com>
To: Andrew MacLeod <amacleod@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [COMMITTED 1/2] Adjust on_entry cache to indicate if the value was set properly.
Date: Fri, 25 Jun 2021 16:58:22 -0600 [thread overview]
Message-ID: <bbbc5d7f-6b21-603e-2918-d5132122f3e6@gmail.com> (raw)
In-Reply-To: <b7092db5-685b-24bb-4db5-7e6a26f5d915@redhat.com>
I just glanced at the patch out of curiosity and the first hunk
caught my eye. There's nothing wrong with the change and I like
how you make the APIs const-correct! Just a note that it looks
like the const in on the basic_block declaration might be missing
an underscore (it should be const_basic_block). Otherwise it's
superfluous. This is repeated in a bunch of places in the file
and its header.
Martin
diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc
index 4347485cf98..bdecd212691 100644
--- a/gcc/gimple-range-cache.cc
+++ b/gcc/gimple-range-cache.cc
@@ -132,7 +132,7 @@ non_null_ref::process_name (tree name)
class ssa_block_ranges
{
public:
- virtual void set_bb_range (const basic_block bb, const irange &r) = 0;
+ virtual bool set_bb_range (const basic_block bb, const irange &r) = 0;
virtual bool get_bb_range (irange &r, const basic_block bb) = 0;
virtual bool bb_range_p (const basic_block bb) = 0;
On 6/23/21 8:27 AM, Andrew MacLeod via Gcc-patches wrote:
> The introduction of the sparse bitmap on-entry cache for large BB
> functions also introduced the concept that the value we ask to be
> written to the cache may not be properly represented. It is limited to
> 15 unique ranges for any given ssa-name, then it reverts to varying for
> any additional values to be safe.
>
> This patch adds a boolean return value to the cache set routines,
> allowing us to check if the value was properly written.
>
> Other than that, no functional change.
>
> Bootstrap on x86_64-pc-linux-gnu with no regressions. pushed.
>
> Andrew
>
prev parent reply other threads:[~2021-06-25 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:27 Andrew MacLeod
2021-06-25 22:58 ` Martin Sebor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbbc5d7f-6b21-603e-2918-d5132122f3e6@gmail.com \
--to=msebor@gmail.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).