From: Jeff Law <jeffreyalaw@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] -finline-stringops: don't assume ptr_mode ptr in memset [PR112804]
Date: Sun, 10 Dec 2023 11:16:06 -0700 [thread overview]
Message-ID: <bbda1047-0e24-4c07-9b84-2126de020c01@gmail.com> (raw)
In-Reply-To: <orttos9kni.fsf@lxoliva.fsfla.org>
On 12/8/23 19:25, Alexandre Oliva wrote:
>
> On aarch64 -milp32, and presumably on other such targets, ptr can be
> in a different mode than ptr_mode in the testcase. Cope with it.
>
> Regstrapped on x86_64-linux-gnu, also tested the new test on
> aarch64-elf. Ok to install?
>
>
> for gcc/ChangeLog
>
> PR target/112804
> * builtins.cc (try_store_by_multiple_pieces): Use ptr's mode
> for the increment.
>
> for gcc/testsuite/ChangeLog
>
> PR target/112804
> * gcc.target/aarch64/inline-mem-set-pr112804.c: New.
Hmmm. I'd like a little more information here I wouldn't expect those
modes to differ even for ILP32 on a 64bit target. Are we just papering
over a problem elsewhere?
Jeff
next prev parent reply other threads:[~2023-12-10 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 2:25 Alexandre Oliva
2023-12-10 18:16 ` Jeff Law [this message]
2023-12-10 22:38 ` Alexandre Oliva
2023-12-10 23:01 ` Andrew Pinski
2023-12-11 6:02 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbda1047-0e24-4c07-9b84-2126de020c01@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).