From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 9BFBF3858D28 for ; Sun, 10 Dec 2023 18:16:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BFBF3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9BFBF3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702232173; cv=none; b=JNNpkqXdBhryzexU8Fim2Fxw87O2xYNjF95cTNAdtTgfhmGkEuqI22b8yQBmuEQUrLYwZlSvBVomw075K4H1mDlel77I4J94LIhFHYscwZ5e+AhVagcfqtsnrVeYjF1CuwQK1eGQYdZIKuUsd6C02f0HDFGMnU0ZEBY+FbXk5e0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702232173; c=relaxed/simple; bh=6HiEXKkmr8WRstRX/5uRpXQLjvksKOlcnZQ+mX4MRnw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ELnI0ykugN+o9YY0Gzr6ff8zeQKeA/mEpV8ZO7D0wV/IPgQpSt/bV9SaonjYZdNFqDaY19+muUQOfGT8Zo/y61U4DRDKusu1jUnXZe9JvdGghcI3NrqB7bpXhkObZPX0FlkD5rQoMyqq96qZPbGFgnqIZcwQJJtLzblJk05ZaYY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d307cf18fdso1664335ad.3 for ; Sun, 10 Dec 2023 10:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702232171; x=1702836971; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TNiqlkj3abghKM+TOONAjMbCujulrrbR3abkQwqDSHE=; b=QC/DPlNylPe0YXMd6xLr4kud6C2OTaH3KxDgp8NyKDcJDazRojqbY8MvrI/CxDbKWf QFZ06yD1rKCOL6Mi9SweuVUnex/LF8t2TlLzmLInyL6KBBFOIR4NtNZI18NtIVomjOnE XOI65kgsGyTtwxQj1266nLpDckv9hucRhbRTWrht9fUm3gc6P1jL62+uVRdtEMLfLxl4 kRQRzgxfahLjLadR1cfzVDg7Pnig7D0JAlM4yUUCEScSnzaftTNpYx/a+c1ZGFaXkOJB dGYoSVaNlhC5koJei6N502TRcE8Iei4Nqrtp2djVZ3x3iBwarIzUl6K2z7o8LSpH5uGE LZ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702232171; x=1702836971; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TNiqlkj3abghKM+TOONAjMbCujulrrbR3abkQwqDSHE=; b=b2pRrnv6HJbqUuQ6LTHYalIBm46ySTtYr2ffe/iiYkbMOXHM9U9+9Dhb8eBgikB55N IKrYeHBMEvesG2SymH1bv1pwG6Ha6SCvHixCV80ZonHBV6dRsiBl5Ka5xlVdowwkGfuh e6ftblkQi+arkDpXMZ/scuw6teGf0B7fxtBK2/6h3Blefq/danelzWkvMjWDYgpXUawL 71ky4eejRuLNMTrDlx/lpW0f9ss39NpIWE6Lsj2hpjg3FNlqMaBGekY+2w4DIBq0WHTE 8uX3cukktfhSnowdfkuJkzQE7aTUl3qhU3w28QZUfsFu6aGzvygPT/sQYhTaPt9Z3TLh PuCA== X-Gm-Message-State: AOJu0YzUq1e4rDUe/ml2LVwVHDesE7JztGitNVMe791zk7HKh8rORhla 9Wr4HOonIeBToyIYdFHXhGxA/SF/XYE= X-Google-Smtp-Source: AGHT+IEWM+RD9RpK1MPeaM8RVOyoTMWImN3nz16LXveY96nmimYkSlhCgCyexK1GJkGAbiONgeBVLw== X-Received: by 2002:a17:902:b204:b0:1d2:ee14:708b with SMTP id t4-20020a170902b20400b001d2ee14708bmr1284475plr.82.1702232171587; Sun, 10 Dec 2023 10:16:11 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id y18-20020a170902b49200b001d1cda6bdfdsm5023251plr.34.2023.12.10.10.16.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 10:16:11 -0800 (PST) Message-ID: Date: Sun, 10 Dec 2023 11:16:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] -finline-stringops: don't assume ptr_mode ptr in memset [PR112804] Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/23 19:25, Alexandre Oliva wrote: > > On aarch64 -milp32, and presumably on other such targets, ptr can be > in a different mode than ptr_mode in the testcase. Cope with it. > > Regstrapped on x86_64-linux-gnu, also tested the new test on > aarch64-elf. Ok to install? > > > for gcc/ChangeLog > > PR target/112804 > * builtins.cc (try_store_by_multiple_pieces): Use ptr's mode > for the increment. > > for gcc/testsuite/ChangeLog > > PR target/112804 > * gcc.target/aarch64/inline-mem-set-pr112804.c: New. Hmmm. I'd like a little more information here I wouldn't expect those modes to differ even for ILP32 on a 64bit target. Are we just papering over a problem elsewhere? Jeff