public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [PowerPC/RTEMS] Add 64-bit support using ELFv2 ABI
Date: Fri, 28 Jul 2017 08:29:00 -0000	[thread overview]
Message-ID: <bc11767f-0093-ab17-8f92-7a785d91dd69@embedded-brains.de> (raw)
In-Reply-To: <20170727195739.GX13471@gate.crashing.org>

On 27/07/17 21:57, Segher Boessenkool wrote:

> On Thu, Jul 27, 2017 at 07:28:30AM +0200, Sebastian Huber wrote:
>>> This deletes eabi.h and I don't see you add all its definitions to
>>> rtems.h directly (NAME__MAIN etc.)  Is this on purpose?
>> Yes, I always wondered why GCC added the __eabi() call to main() out of
>> thin air. In general, there is no main() function in RTEMS. Instead, you
>> can statically configure initialization threads. We call __eabi() in the
>> low-level startup code, e.g.
>>
>> https://git.rtems.org/rtems/tree/c/src/lib/libbsp/powerpc/qoriq/start/start.S#n144
> Heh, I always thought the EABI must require it, but it seems to be a GCC
> invention.
>
> Patch looks fine to me then.  You can approve it yourself of course:-)

Thanks for your review, I checked it in in mainline and 7 branch.

Would you mind having a look at:

https://gcc.gnu.org/ml/gcc/2017-07/msg00196.html

Is the small data area no longer supported by GCC for 64-bit PowerPC?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

  reply	other threads:[~2017-07-28  8:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 12:25 Sebastian Huber
2017-07-26 17:56 ` Segher Boessenkool
2017-07-27  5:28   ` Sebastian Huber
2017-07-27 19:57     ` Segher Boessenkool
2017-07-28  8:29       ` Sebastian Huber [this message]
2017-07-28 17:37         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc11767f-0093-ab17-8f92-7a785d91dd69@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).