From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id E718C3858D1E for ; Thu, 10 Nov 2022 14:02:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E718C3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C91BB1FD0A; Thu, 10 Nov 2022 14:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668088941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLXP3DiKyhzOCQTl0tz0DcWZbptjie+gmyyZ9S3t41g=; b=ItXXO9hFAxVZiSdsC6+ozyJRJsNDO6DVI+K9MAxsHrkPidPWEDJ2eDSmeHX7eXoqKLSvtN nQCHBwYD0Jh9NOKegA9W8H/FQtw9GIswG8iFCUvcxEVIR6cJju48L4sV9Hurt/QgffRy5p DXMNrxBFxVA5qulMG7qJBWddUiMdDQk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668088941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLXP3DiKyhzOCQTl0tz0DcWZbptjie+gmyyZ9S3t41g=; b=oFLcTeYYZzK3m5x4k0dSkJ08iHsEuJrBDeOrh1RiqoVpbbttmP4B1h5u4EI/UBu30ZUtxV hXi3azuj11BjApBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B1BD21332F; Thu, 10 Nov 2022 14:02:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6J7fKW0EbWOQEgAAMHmgww (envelope-from ); Thu, 10 Nov 2022 14:02:21 +0000 Message-ID: Date: Thu, 10 Nov 2022 15:02:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality Content-Language: en-US To: Thomas Schwinge , Richard Biener Cc: gcc-patches@gcc.gnu.org References: <10a94ccc-e01b-b98a-0fcb-cd661c10c315@suse.cz> <87k04b2hgb.fsf@euler.schwinge.homeip.net> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <87k04b2hgb.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/4/22 10:32, Thomas Schwinge wrote: > Hi! > > On 2022-09-01T12:05:23+0200, Martin Liška wrote: >> gcc/ChangeLog: > >> --- a/gcc/system.h >> +++ b/gcc/system.h >> @@ -1009,8 +1009,7 @@ extern void fancy_abort (const char *, int, const char *) >> ASM_OUTPUT_DEFINE_LABEL_DIFFERENCE_SYMBOL HOST_WORDS_BIG_ENDIAN \ >> OBJC_PROLOGUE ALLOCATE_TRAMPOLINE HANDLE_PRAGMA ROUND_TYPE_SIZE \ >> ROUND_TYPE_SIZE_UNIT CONST_SECTION_ASM_OP CRT_GET_RFIB_TEXT \ >> - DBX_LBRAC_FIRST DBX_OUTPUT_ENUM DBX_OUTPUT_SOURCE_FILENAME \ >> - DBX_WORKING_DIRECTORY INSN_CACHE_DEPTH INSN_CACHE_SIZE \ >> + INSN_CACHE_DEPTH INSN_CACHE_SIZE \ >> INSN_CACHE_LINE_WIDTH INIT_SECTION_PREAMBLE NEED_ATEXIT ON_EXIT \ >> EXIT_BODY OBJECT_FORMAT_ROSE MULTIBYTE_CHARS MAP_CHARACTER \ >> LIBGCC_NEEDS_DOUBLE FINAL_PRESCAN_LABEL DEFAULT_CALLER_SAVES \ >> @@ -1023,15 +1022,14 @@ extern void fancy_abort (const char *, int, const char *) >> MAX_WCHAR_TYPE_SIZE SHARED_SECTION_ASM_OP INTEGRATE_THRESHOLD \ >> FINAL_REG_PARM_STACK_SPACE MAYBE_REG_PARM_STACK_SPACE \ >> TRADITIONAL_PIPELINE_INTERFACE DFA_PIPELINE_INTERFACE \ >> - DBX_OUTPUT_STANDARD_TYPES BUILTIN_SETJMP_FRAME_VALUE \ >> + BUILTIN_SETJMP_FRAME_VALUE \ >> SUNOS4_SHARED_LIBRARIES PROMOTE_FOR_CALL_ONLY \ >> SPACE_AFTER_L_OPTION NO_RECURSIVE_FUNCTION_CSE \ >> DEFAULT_MAIN_RETURN TARGET_MEM_FUNCTIONS EXPAND_BUILTIN_VA_ARG \ >> COLLECT_PARSE_FLAG DWARF2_GENERATE_TEXT_SECTION_LABEL WINNING_GDB \ >> ASM_OUTPUT_FILENAME ASM_OUTPUT_SOURCE_LINE FILE_NAME_JOINER \ >> - GDB_INV_REF_REGPARM_STABS_LETTER DBX_MEMPARM_STABS_LETTER \ >> - PUT_SDB_SRC_FILE STABS_GCC_MARKER DBX_OUTPUT_FUNCTION_END \ >> - DBX_OUTPUT_GCC_MARKER DBX_FINISH_SYMBOL SDB_GENERATE_FAKE \ >> + GDB_INV_REF_REGPARM_STABS_LETTER \ >> + PUT_SDB_SRC_FILE STABS_GCC_MARKER SDB_GENERATE_FAKE \ >> NON_SAVING_SETJMP TARGET_LATE_RTL_PROLOGUE_EPILOGUE \ >> CASE_DROPS_THROUGH TARGET_BELL TARGET_BS TARGET_CR TARGET_DIGIT0 \ >> TARGET_ESC TARGET_FF TARGET_NEWLINE TARGET_TAB TARGET_VT \ >> @@ -1056,8 +1054,8 @@ extern void fancy_abort (const char *, int, const char *) >> PREFERRED_OUTPUT_RELOAD_CLASS SYSTEM_INCLUDE_DIR \ >> STANDARD_INCLUDE_DIR STANDARD_INCLUDE_COMPONENT \ >> LINK_ELIMINATE_DUPLICATE_LDIRECTORIES MIPS_DEBUGGING_INFO \ >> - IDENT_ASM_OP ALL_COP_ADDITIONAL_REGISTER_NAMES DBX_OUTPUT_LBRAC \ >> - DBX_OUTPUT_NFUN DBX_OUTPUT_RBRAC RANGE_TEST_NON_SHORT_CIRCUIT \ >> + IDENT_ASM_OP ALL_COP_ADDITIONAL_REGISTER_NAMES \ >> + RANGE_TEST_NON_SHORT_CIRCUIT \ >> REAL_VALUE_TRUNCATE REVERSE_CONDEXEC_PREDICATES_P \ >> TARGET_ALIGN_ANON_BITFIELDS TARGET_NARROW_VOLATILE_BITFIELDS \ >> IDENT_ASM_OP UNALIGNED_SHORT_ASM_OP UNALIGNED_INT_ASM_OP \ > > These changes are part of > commit r13-2361-g7e0db0cdf01e9c885a29cb37415f5bc00d90c029 > "STABS: remove -gstabs and -gxcoff functionality". What this does is > remove these identifiers from "poisoning": > > /* As the last action in this file, we poison the identifiers that > shouldn't be used. > [...] > /* Other obsolete target macros, or macros that used to be in target > headers and were not used, and may be obsolete or may never have > been used. */ > #pragma GCC poison [...] > > Shouldn't these identifiers actually stay (so that any accidental future > use gets flagged, as I understand this machinery), and instead more > identifiers be added potentially: those where their definition/use got > removed with "STABS: remove -gstabs and -gxcoff functionality"? (I've > not checked.) Well, the identifiers are not used any longer, so I don't think we should poison them. Or do I miss something? Martin > > > Grüße > Thomas > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955