From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1579 invoked by alias); 27 Dec 2018 11:24:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1388 invoked by uid 89); 27 Dec 2018 11:24:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy=conform, OKd, okd, Kargl X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30064.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.64) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Dec 2018 11:24:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GFAMipG8ROrRVD62bdZaTKyO9Kk2NrtB1zb/UPDq39Q=; b=Z2sv47f3ooz3AvvgDZCQ5Bt1RQjLad4rpRQnyzSVVRrllfwVqG5JvB3BC1CSMfmvXvdieYtj2RkrKNG+E4xtmIJR2RAwo4AzVN1rU3khq+9LEAmCJtDHW2cC/m0BcdHmjiASNX7tetHNVh4wbImph6gQZ77FDv/Nq9kivHHgcxE= Received: from HE1PR0801MB1722.eurprd08.prod.outlook.com (10.168.149.146) by HE1PR0801MB1753.eurprd08.prod.outlook.com (10.168.150.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.21; Thu, 27 Dec 2018 11:24:07 +0000 Received: from HE1PR0801MB1722.eurprd08.prod.outlook.com ([fe80::a405:8891:2433:3011]) by HE1PR0801MB1722.eurprd08.prod.outlook.com ([fe80::a405:8891:2433:3011%8]) with mapi id 15.20.1471.019; Thu, 27 Dec 2018 11:24:07 +0000 From: Sudakshina Das To: "sgk@troutmask.apl.washington.edu" , "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" CC: nd Subject: Re: [PATCH] PR fortran/81509 and fortran/45513 Date: Thu, 27 Dec 2018 14:59:00 -0000 Message-ID: References: <20181223184920.GA87482@troutmask.apl.washington.edu> In-Reply-To: <20181223184920.GA87482@troutmask.apl.washington.edu> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Sudi.Das@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="Windows-1252" Content-ID: <41E5814DA8EE714F9117BBA0B995B474@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01698.txt.bz2 Hi Steve On 23/12/18 6:49 PM, Steve Kargl wrote: > This is a re-submission of a patch I submitted 15 months ago. > See https://gcc.gnu.org/ml/fortran/2017-09/msg00124.html > > At that time one reviewer OK'd the patch for committing, > and one reviewer raised objections to the patch as I > chose to remove dubious extensions to the Fortran standard. > I withdrew that patch with the expection that Someone > would fix the bug. Well, Someone has not materialized. > > The patch has been retested on i586-*-freebsd and x86_64-*-freebsd. > > OK to commit as-is? > > Here's the text from the above URL. > > In short, F2008 now allows boz-literal-constants in IAND, IOR, IEOR, > DSHIFTL, DSHIFTR, and MERGE_BITS. gfortran currently allows a BOZ > argument, but she was not enforcing restrictions in F2008. The > attach patch causes gfortran to conform to F2008. > > As a side effect, the patch removes a questionable GNU Fortran > extension that allowed arguments to IAND, IOR, and IEOR to have > different kind type parameters. The behavior of this extension > was not documented. > > 2017-09-27 Steven G. Kargl > > PR fortran/45513 > PR fortran/81509 > * check.c: Rename function gfc_check_iand to gfc_check_iand_ieor_ior. > * check.c (boz_args_check): New function. Check I and J not both BOZ. > (gfc_check_dshift,gfc_check_iand_ieor_ior, gfc_check_ishft, > gfc_check_and, gfc_check_merge_bits): Use it. > * check.c (gfc_check_iand_ieor_ior): Force conversion of BOZ to kind > type of other agrument. Remove silly GNU extension. > (gfc_check_ieor, gfc_check_ior): Delete now unused functions. > * intrinsic.c (add_functions): Use gfc_check_iand_ieor_ior. Wrap long > line. > * intrinsic.h: Rename gfc_check_iand to gfc_check_iand_ieor_ior. > Delete prototype for bool gfc_check_ieor and gfc_check_ior > * intrinsic.texi: Update documentation for boz-literal-constant. > > 2017-09-27 Steven G. Kargl > > PR fortran/45513 > PR fortran/81509 > * gfortran.dg/graphite/id-26.f03: Fix non-conforming use of IAND. > * gfortran.dg/pr81509_1.f90: New test. > * gfortran.dg/pr81509_2.f90: New test. > This patch has caused the following failures on aarch64-none-linux-gnu: FAIL: libgomp.fortran/aligned1.f03=A0=A0 -O0=A0 (test for excess errors) FAIL: libgomp.fortran/aligned1.f03=A0=A0 -O1=A0 (test for excess errors) FAIL: libgomp.fortran/aligned1.f03=A0=A0 -O2=A0 (test for excess errors) FAIL: libgomp.fortran/aligned1.f03=A0=A0 -O3 -fomit-frame-pointer=20 -funroll-loops -fpeel-loops -ftracer -finline-functions=A0 (test for=20 excess errors) FAIL: libgomp.fortran/aligned1.f03=A0=A0 -O3 -g=A0 (test for excess errors) FAIL: libgomp.fortran/aligned1.f03=A0=A0 -Os=A0 (test for excess errors) With the failure as: Excess errors: /build/src/gcc/libgomp/testsuite/libgomp.fortran/aligned1.f03:55:14:=20 Error: Arguments of 'iand' have different kind type parameters at (1) /build/src/gcc/libgomp/testsuite/libgomp.fortran/aligned1.f03:59:14:=20 Error: Arguments of 'iand' have different kind type parameters at (1) Thanks Sudi