[PATCH ver3] rs6000, altivec-1-runnable.c update the, require-effective-target

[PATCH ver3] rs6000, altivec-1-runnable.c update the, require-effective-target

[Carl Love]

GCC maintainers:

version 3, rebased on current mainline tree.  Version 2 of the patch was out of sync. Retested the patch on 
Power 10 with no regressions.

version 2, update the dg options per the feedback.  Retested the patch on Power 10 with no regressions.

This patch updates the dg options.

The patch has been tested on Power 10 with no regression failures.

Please let me know if this patch is acceptable for mainline.  Thanks.

                        Carl 


------------------------------------------------------------
rs6000, altivec-1-runnable.c update the require-effective-target

Update the dg test directives.

gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog:
	* gcc.target/powerpc/altivec-1-runnable.c: Change the
	require-effective-target for the test.
---
 gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
index 4e32860a169..6763ff3ff8b 100644
--- a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
+++ b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
@@ -1,7 +1,9 @@
-/* { dg-do compile { target powerpc*-*-* } } */
-/* { dg-options "-maltivec" } */
+/* { dg-do run { target vmx_hw } } */
+/* { dg-do compile { target { ! vmx_hw } } } */
+/* { dg-options "-O2 -maltivec" } */
 /* { dg-require-effective-target powerpc_altivec } */
 
+
 #include <altivec.h>
 
 #ifdef DEBUG
-- 
2.45.0

Re: [PATCH ver3] rs6000, altivec-1-runnable.c update the, require-effective-target

[Kewen.Lin]

Hi,

on 2024/6/25 03:00, Carl Love wrote:
> GCC maintainers:
> 
> version 3, rebased on current mainline tree.  Version 2 of the patch was out of sync. Retested the patch on 
> Power 10 with no regressions.
> 
> version 2, update the dg options per the feedback.  Retested the patch on Power 10 with no regressions.
> 
> This patch updates the dg options.
> 
> The patch has been tested on Power 10 with no regression failures.
> 
> Please let me know if this patch is acceptable for mainline.  Thanks.
> 
>                         Carl 
> 
> 
> ------------------------------------------------------------
> rs6000, altivec-1-runnable.c update the require-effective-target
> 
> Update the dg test directives.

OK with the very minor nit below tweaked, thanks!

> 
> gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog:
> 	* gcc.target/powerpc/altivec-1-runnable.c: Change the
> 	require-effective-target for the test.
> ---
>  gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
> index 4e32860a169..6763ff3ff8b 100644
> --- a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
> +++ b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
> @@ -1,7 +1,9 @@
> -/* { dg-do compile { target powerpc*-*-* } } */
> -/* { dg-options "-maltivec" } */
> +/* { dg-do run { target vmx_hw } } */
> +/* { dg-do compile { target { ! vmx_hw } } } */
> +/* { dg-options "-O2 -maltivec" } */
>  /* { dg-require-effective-target powerpc_altivec } */
>  
> +

Nit: This newline is useless.

BR,
Kewen

>  #include <altivec.h>
>  
>  #ifdef DEBUG