From: Harald Anlauf <anlauf@gmx.de>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Cc: fortran@gcc.gnu.org, Paul Richard Thomas <paul.richard.thomas@gmail.com>
Subject: Re: [PATCH] Only return after resetting type_param_spec_list
Date: Mon, 29 Nov 2021 20:36:59 +0100 [thread overview]
Message-ID: <bc954bd0-3d8a-62b8-66b2-9fb48c8db69a@gmx.de> (raw)
In-Reply-To: <qnn8n3os-442o-ps3r-1o28-461r60s111s@fhfr.qr>
Am 29.11.21 um 12:28 schrieb Richard Biener via Fortran:
> This fixes an appearant mistake in gfc_insert_parameter_exprs.
Yes, that looks pretty much like a missed cleanup and fix during
development. CC'ing Paul.
> Bootstrap / regtest pending on x86_64-unknown-linux-gnu.
>
> OK?
LGTM if it regtests.
Thanks,
Harald
> Thanks,
> Richard.
>
> 2021-11-29 Richard Biener <rguenther@suse.de>
>
> gcc/fortran/
> * decl.c (gfc_insert_parameter_exprs): Only return after
> resetting type_param_spec_list.
> ---
> gcc/fortran/decl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/fortran/decl.c b/gcc/fortran/decl.c
> index c0fec90e3e0..4971638f9b6 100644
> --- a/gcc/fortran/decl.c
> +++ b/gcc/fortran/decl.c
> @@ -3733,9 +3733,9 @@ gfc_insert_parameter_exprs (gfc_expr *e, gfc_actual_arglist *param_list)
> {
> gfc_actual_arglist *old_param_spec_list = type_param_spec_list;
> type_param_spec_list = param_list;
> - return gfc_traverse_expr (e, NULL, &insert_parameter_exprs, 1);
> - type_param_spec_list = NULL;
> + bool res = gfc_traverse_expr (e, NULL, &insert_parameter_exprs, 1);
> type_param_spec_list = old_param_spec_list;
> + return res;
> }
>
> /* Determines the instance of a parameterized derived type to be used by
>
prev parent reply other threads:[~2021-11-29 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 11:28 Richard Biener
2021-11-29 19:36 ` Harald Anlauf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc954bd0-3d8a-62b8-66b2-9fb48c8db69a@gmx.de \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).