From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id D7C273858409; Mon, 29 Nov 2021 19:37:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7C273858409 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gluon.fritz.box ([79.251.15.55]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49hB-1mRHGG0Ykr-0102wF; Mon, 29 Nov 2021 20:37:01 +0100 Subject: Re: [PATCH] Only return after resetting type_param_spec_list To: Richard Biener , gcc-patches@gcc.gnu.org Cc: fortran@gcc.gnu.org, Paul Richard Thomas Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: From: Harald Anlauf Message-ID: Date: Mon, 29 Nov 2021 20:36:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:HbHmvXE4a8Fg+WIlZiNtQqPbntK5Xg0CgfrjXyK79PY5Qhh1b6g VCmUDzMKDQN9zv1BOpkb+8vvdWM7C0vv16ZFCK1KvwO//ALQnZsWtFmO9IJnA4kE1iVv7Zd zgqLv6PJJg9QUzX/Cpw4RoZkDum7FUMZYiMpbK5cDUe60bt4kafKaOcJczxXCNwAR2NHQIq GDiEHjdkcZC7m6OyuWPuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Omn2WZDwzRs=:eEwF+gRYRnsWNRXK2OptWT sBHAeaYSSN8UnoB4l68beIlp6KU3TLmMZ/HyStFlc0/ml2lnp3+G2zntaLZZClreMHBd34pSs f1ubMVeJKZqR9suBFKwcKXz1uI5jnAXwJG/A1N/yKWKzRZov6SXebNK30zyY8L178hBbCaUev kRqeiOzHEahW5MXAZ47lWQBPg+3/B20O0MJkSVFuC3NaAzFeYw0fqBTFCJ4Sy+eGrOHVjOK+r pZRFTDc8hNujBXLOLPaw/Ia9ayDkRn7eUmZsnUkf/UxT5iE+ZuWUMlPBPtsTH//C57BI2f/SC x+OHmOhLwfWWI89nNBh+e9ptkW1ccHS+c1440mPDEZVEntJ0IwGuXH/TTv8NxF8Prt3JlnZQu El776pUIn1GY3fJ+zrkFZqtguaeNoMP7yxGq9vSfXh56L0UOALeq2EyO5oV9rIT+DK8LBQrqE Fw+so2D+YbGVIb7IVbBO8BhJliKRgo1XvXsdpTEUyhsInYk0Ky5ybv5JPWnaFu3ghxv0bDBO8 ZyKJAx4icsU6Bu36wPHxXackG/GesdKGMdUHKprreq87DvZZTxPEM0/4w1v+MyRFL2f00OnhY ePaJKGSe0Mrxd3W9B+U3GaVUWrWDQc4Z4+at9ec5/4MaPYZ3eweXvLKdw/4RYJZxCWRlC3Hba MHxrmZbUu3P/MTJUSFWj0cdsFmYUcW0KCwvq/CqyHqVS1UvK5Wf10jcByVRyQwnCwKzQPCvuC l6U7e71JojvrYoWLk8mr8fP4K9nA6/BuOvUaVvY3e/E8y+jfSjLNCOFmcL2o6shL2IwxzDnS1 k2fb1XqnZ24qrKkur7SEkrka8rV+mFqIobSJZzM+aq92VbffbrJTs9h7vEwBgOtoe559N/NnL MFp09FTvJubS8psaQQgfwpkLr9+lAFHkmb4b8Q+EgMgkPSyI3bIaKF9HxDUqm+4WJrfa/dl2u ZVxS8F3+cPCrFsVwPbPisCfUDtd7L34QJz+0v77now/LBF1Wo0WhUHgqD8kmoPGyJehkqXGGs +LfaiKsqPMo81ddsGm9hPNby9c0lYDq/MsK2xr62ggCJMQ0N+vDXzScm1hUdqc4JKTA8yX05e meWpGxEGWwsd88= X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2021 19:37:05 -0000 Am 29.11.21 um 12:28 schrieb Richard Biener via Fortran: > This fixes an appearant mistake in gfc_insert_parameter_exprs. Yes, that looks pretty much like a missed cleanup and fix during development. CC'ing Paul. > Bootstrap / regtest pending on x86_64-unknown-linux-gnu. > > OK? LGTM if it regtests. Thanks, Harald > Thanks, > Richard. > > 2021-11-29 Richard Biener > > gcc/fortran/ > * decl.c (gfc_insert_parameter_exprs): Only return after > resetting type_param_spec_list. > --- > gcc/fortran/decl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/fortran/decl.c b/gcc/fortran/decl.c > index c0fec90e3e0..4971638f9b6 100644 > --- a/gcc/fortran/decl.c > +++ b/gcc/fortran/decl.c > @@ -3733,9 +3733,9 @@ gfc_insert_parameter_exprs (gfc_expr *e, gfc_actua= l_arglist *param_list) > { > gfc_actual_arglist *old_param_spec_list =3D type_param_spec_list; > type_param_spec_list =3D param_list; > - return gfc_traverse_expr (e, NULL, &insert_parameter_exprs, 1); > - type_param_spec_list =3D NULL; > + bool res =3D gfc_traverse_expr (e, NULL, &insert_parameter_exprs, 1); > type_param_spec_list =3D old_param_spec_list; > + return res; > } > > /* Determines the instance of a parameterized derived type to be used = by >