From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix factor_out_conditional_conversion caused ICE (PR tree-optimization/83521)
Date: Thu, 21 Dec 2017 23:14:00 -0000 [thread overview]
Message-ID: <bcbf3323-92b7-66fa-02c6-9ce8befbcb92@redhat.com> (raw)
In-Reply-To: <20171221175045.GA2353@tucnak>
On 12/21/2017 10:50 AM, Jakub Jelinek wrote:
> Hi!
>
> The problem here is that the code expects fold_build1 will actually not
> fold, because using gimple_build_assign (..., VIEW_CONVERT_EXPR, temp);
> is valid only if TREE_CODE (temp) == VIEW_CONVERT_EXPR.
> So, either we can replace the fold_build1 with build1, or we should just
> use the gimple_build_assign overload that will handle even what
> <view_convert_expr <SSA_NAME_result_of_phi>> will fold to (in this case
> a <nop_expr <SSA_NAME_result_of_phi>>).
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2017-12-21 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/83521
> * tree-ssa-phiopt.c (factor_out_conditional_conversion): Use
> gimple_build_assign without code on result of
> fold_build1 (VIEW_CONVERT_EXPR, ...), as it might not create
> a VIEW_CONVERT_EXPR.
>
> * gcc.dg/pr83521.c: New test.
OK.
jeff
prev parent reply other threads:[~2017-12-21 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 17:50 Jakub Jelinek
2017-12-21 18:57 ` Richard Biener
2017-12-21 23:14 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbf3323-92b7-66fa-02c6-9ce8befbcb92@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).