From: "Martin Liška" <mliska@suse.cz>
To: Tobias Burnus <tobias@codesourcery.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] Revert 'Use more ARRAY_SIZE.' for mkoffload (was: [PATCH] Use more ARRAY_SIZE.)
Date: Wed, 18 May 2022 09:40:13 +0200 [thread overview]
Message-ID: <bcd0d209-8bc8-afc5-9043-440464fcbf31@suse.cz> (raw)
In-Reply-To: <ed8da6d6-8fa6-1e17-3238-5fe937cbb340@codesourcery.com>
On 5/17/22 21:03, Tobias Burnus wrote:
> This patch broke offloading – fixed by reverting the patch for
> {gcn,nvptx}/mkoffload.cc – and committed as obvious. Changing a C-code
> generating string without telling the then called C compiler about the
> macro won't fly. See attachment for
> r13-569-gc9852156dd2fedec130f6d8eb669579ef6237946, which reverts it for
> mkoffload.cc, only.
Thank you for the fix and sorry for the code breakage ;)
Cheers,
Martin
next prev parent reply other threads:[~2022-05-18 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 12:16 [PATCH] Use more ARRAY_SIZE Martin Liška
2022-05-05 12:58 ` Iain Buclaw
2022-05-05 14:29 ` Martin Liška
2022-05-09 12:03 ` Richard Biener
2022-05-11 8:17 ` Martin Liška
2022-05-12 9:26 ` Mikael Morin
2022-05-16 8:39 ` Martin Liška
2022-05-17 19:03 ` [committed] Revert 'Use more ARRAY_SIZE.' for mkoffload (was: [PATCH] Use more ARRAY_SIZE.) Tobias Burnus
2022-05-18 7:40 ` Martin Liška [this message]
2022-05-23 7:56 ` [PATCH] Use more ARRAY_SIZE Iain Buclaw
2022-05-23 11:57 ` Martin Liška
2022-05-09 10:21 ` Arnaud Charlet
2022-05-09 10:53 ` Martin Liška
2022-05-09 11:00 ` Arnaud Charlet
2022-05-11 13:52 ` David Malcolm
2022-05-11 19:04 ` Eric Gallager
2022-05-11 19:59 ` David Malcolm
2022-05-12 7:08 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd0d209-8bc8-afc5-9043-440464fcbf31@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).