From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F191138582AC for ; Tue, 18 Jul 2023 17:37:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F191138582AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689701847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mDNpGF231C/khNR4g7KstQwT93BWzia38axg4HsHTlU=; b=TjfaO2ZCoby635YpFprL5kjYufskhH7UaQhPWs3cZG8RVNzsc1KxHq24+LQ99TAjd/4dWh HpLpgACy4f1CB1BMlgxWcx6obZzKknb82HDT2V3A+TeH5QbmvmVWGNYtbrsxK52x6nvgsL RN2u21D7x8YCoDR2PqDn3bA+OKoQy1Q= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-Wg3MJ2GMPhiRYHUtsG4Gdw-1; Tue, 18 Jul 2023 13:37:22 -0400 X-MC-Unique: Wg3MJ2GMPhiRYHUtsG4Gdw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fb416d7731so33814685e9.2 for ; Tue, 18 Jul 2023 10:37:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689701841; x=1692293841; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3bTenXlzAN4WfZnVdDSWTdF7eiwuiECw217BjBCDnWU=; b=hefcwqFeMQb2TptXRul7Py/FB515aLrSVU8MzDO12GI8t6eB59dAF0mAR9pgb6/l4x K8F3JFeJm+bMwPJg9IhE+4MBtzzHoGxplhL37/ZtZVBhItSx88sXNlOYpvYUkFII98/Q 3aPQitjTXcekTsXTX8CKEl5a0xlqGGkLub/t2yRCW39w5kg8JodlkWqfS50VOaOtRs8+ CDfqbLroT5+RfxtnNH8GhGzDf+BMSdJzZ0kmBp6CpxQSH4gxRUpRDsmg5feYF2HxYCuc BtCk079Qn7aTYeAOdKOoFAV22WSjJ1NO9KWfjyw5yaWTm2I3Axd+Fb0Y3Sw2nPY3imjs mWzA== X-Gm-Message-State: ABy/qLZN5kmj3/K/e4S9MPfkh7CdFhNra7VgG6tZT68Ktu5iPhNq1ovl yLM2yVVQRIjxUmGeQ/14DXCPpV+6dvWVlQHKOsZPxH8KGIacyNSzxRVJnmm63aiW7R1nKY+nLUJ kHgdA4b3RMWrff46+xZ9lSI1STWh3dzJFmUkqZN6XOLOzSzfcfyQ4lN8XqavOmiFam4bMO/08Fw == X-Received: by 2002:a7b:c387:0:b0:3fb:c217:722e with SMTP id s7-20020a7bc387000000b003fbc217722emr57590wmj.33.1689701840967; Tue, 18 Jul 2023 10:37:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHCBA9N6oaM79JNm2bvKzblf4uMlcdx2fMHWUta8MgmNDRbu1CYITxcvvE8w8igRfUGhx+vhQ== X-Received: by 2002:a7b:c387:0:b0:3fb:c217:722e with SMTP id s7-20020a7bc387000000b003fbc217722emr57573wmj.33.1689701840574; Tue, 18 Jul 2023 10:37:20 -0700 (PDT) Received: from [192.168.1.201] ([139.47.41.96]) by smtp.gmail.com with ESMTPSA id y13-20020a05600c364d00b003f819faff24sm10707710wmq.40.2023.07.18.10.37.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 10:37:20 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 19:37:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] Read global value/mask in IPA. To: GCC patches Cc: Andrew MacLeod , Martin Jambor References: <20230717131411.330650-1-aldyh@redhat.com> From: Aldy Hernandez In-Reply-To: <20230717131411.330650-1-aldyh@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------vV5FPDnDO5v0kyKOk6YJijzh" Content-Language: en-US X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------vV5FPDnDO5v0kyKOk6YJijzh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/17/23 15:14, Aldy Hernandez wrote: > Instead of reading the known zero bits in IPA, read the value/mask > pair which is available. > > There is a slight change of behavior here. I have removed the check > for SSA_NAME, as the ranger can calculate the range and value/mask for > INTEGER_CST. This simplifies the code a bit, since there's no special > casing when setting the jfunc bits. The default range for VR is > undefined, so I think it's safe just to check for undefined_p(). Final round of tests revealed a regression for which I've adjusted the testcase. It turns out g++.dg/ipa/pure-const-3.C fails because IPA can now pick up value/mask from any pass that has an integrated ranger. The test was previously disabling evrp and CCP, but now VRP[12], jump threading, and DOM can make value/mask adjustments visible to IPA so they must be disabled as well. We've run into these scenarios multiple times in the past-- any improvements to the ranger pipeline causes everyone to get smarter, making changes visible earlier in the pipeline. Aldy --------------vV5FPDnDO5v0kyKOk6YJijzh Content-Type: text/x-patch; charset=UTF-8; name="0001-Read-global-value-mask-in-IPA.patch" Content-Disposition: attachment; filename="0001-Read-global-value-mask-in-IPA.patch" Content-Transfer-Encoding: base64 RnJvbSBlMWRmZDRkNmIzZDNiZjA5ZDU1YjZlYTNhYzczMjQ2MmM3MDMwODAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogRnJpLCAxNCBKdWwgMjAyMyAxMjozODoxNiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFJlYWQg Z2xvYmFsIHZhbHVlL21hc2sgaW4gSVBBLgoKSW5zdGVhZCBvZiByZWFkaW5nIHRoZSBrbm93biB6 ZXJvIGJpdHMgaW4gSVBBLCByZWFkIHRoZSB2YWx1ZS9tYXNrCnBhaXIgd2hpY2ggaXMgYXZhaWxh YmxlLgoKVGhlcmUgaXMgYSBzbGlnaHQgY2hhbmdlIG9mIGJlaGF2aW9yIGhlcmUuICBJIGhhdmUg cmVtb3ZlZCB0aGUgY2hlY2sKZm9yIFNTQV9OQU1FLCBhcyB0aGUgcmFuZ2VyIGNhbiBjYWxjdWxh dGUgdGhlIHJhbmdlIGFuZCB2YWx1ZS9tYXNrIGZvcgpJTlRFR0VSX0NTVC4gIFRoaXMgc2ltcGxp ZmllcyB0aGUgY29kZSBhIGJpdCwgc2luY2UgdGhlcmUncyBubyBzcGVjaWFsCmNhc2luZyB3aGVu IHNldHRpbmcgdGhlIGpmdW5jIGJpdHMuICBUaGUgZGVmYXVsdCByYW5nZSBmb3IgVlIgaXMKdW5k ZWZpbmVkLCBzbyBJIHRoaW5rIGl0J3Mgc2FmZSBqdXN0IHRvIGNoZWNrIGZvciB1bmRlZmluZWRf cCgpLgoKZ2NjL0NoYW5nZUxvZzoKCgkqIGlwYS1wcm9wLmNjIChpcGFfY29tcHV0ZV9qdW1wX2Z1 bmN0aW9uc19mb3JfZWRnZSk6IFJlYWQgZ2xvYmFsCgl2YWx1ZS9tYXNrLgoKZ2NjL3Rlc3RzdWl0 ZS9DaGFuZ2VMb2c6CgoJKiBnKysuZGcvaXBhL3B1cmUtY29uc3QtMy5DOiBBZGp1c3QgZm9yIHNt YXJ0ZXIgdmFsdWUvbWFzayBiZWluZwoJcmVhZCBieSByYW5nZXIgZWFybGllciB0aGFuIGV4cGVj dGVkIGJ5IHRlc3QuCi0tLQogZ2NjL2lwYS1wcm9wLmNjICAgICAgICAgICAgICAgICAgICAgICAg IHwgMTggKysrKysrKystLS0tLS0tLS0tCiBnY2MvdGVzdHN1aXRlL2crKy5kZy9pcGEvcHVyZS1j b25zdC0zLkMgfCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDExIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2djYy9pcGEtcHJvcC5jYyBiL2djYy9pcGEtcHJvcC5j YwppbmRleCA1ZDc5MGZmMTI2NS4uNGY2ZWQ3Yjg5YmQgMTAwNjQ0Ci0tLSBhL2djYy9pcGEtcHJv cC5jYworKysgYi9nY2MvaXBhLXByb3AuY2MKQEAgLTI0MDIsOCArMjQwMiw3IEBAIGlwYV9jb21w dXRlX2p1bXBfZnVuY3Rpb25zX2Zvcl9lZGdlIChzdHJ1Y3QgaXBhX2Z1bmNfYm9keV9pbmZvICpm YmksCiAJfQogICAgICAgZWxzZQogCXsKLQkgIGlmIChUUkVFX0NPREUgKGFyZykgPT0gU1NBX05B TUUKLQkgICAgICAmJiBwYXJhbV90eXBlCisJICBpZiAocGFyYW1fdHlwZQogCSAgICAgICYmIFZh bHVlX1JhbmdlOjpzdXBwb3J0c190eXBlX3AgKFRSRUVfVFlQRSAoYXJnKSkKIAkgICAgICAmJiBW YWx1ZV9SYW5nZTo6c3VwcG9ydHNfdHlwZV9wIChwYXJhbV90eXBlKQogCSAgICAgICYmIGlyYW5n ZTo6c3VwcG9ydHNfcCAoVFJFRV9UWVBFIChhcmcpKQpAQCAtMjQyMiwxNSArMjQyMSwxNCBAQCBp cGFfY29tcHV0ZV9qdW1wX2Z1bmN0aW9uc19mb3JfZWRnZSAoc3RydWN0IGlwYV9mdW5jX2JvZHlf aW5mbyAqZmJpLAogCSAgICBnY2NfYXNzZXJ0ICghamZ1bmMtPm1fdnIpOwogCX0KIAotICAgICAg aWYgKElOVEVHUkFMX1RZUEVfUCAoVFJFRV9UWVBFIChhcmcpKQotCSAgJiYgKFRSRUVfQ09ERSAo YXJnKSA9PSBTU0FfTkFNRSB8fCBUUkVFX0NPREUgKGFyZykgPT0gSU5URUdFUl9DU1QpKQorICAg ICAgaWYgKElOVEVHUkFMX1RZUEVfUCAoVFJFRV9UWVBFIChhcmcpKSAmJiAhdnIudW5kZWZpbmVk X3AgKCkpCiAJewotCSAgaWYgKFRSRUVfQ09ERSAoYXJnKSA9PSBTU0FfTkFNRSkKLQkgICAgaXBh X3NldF9qZnVuY19iaXRzIChqZnVuYywgMCwKLQkJCQl3aWRlc3RfaW50Ojpmcm9tIChnZXRfbm9u emVyb19iaXRzIChhcmcpLAotCQkJCQkJICBUWVBFX1NJR04gKFRSRUVfVFlQRSAoYXJnKSkpKTsK LQkgIGVsc2UKLQkgICAgaXBhX3NldF9qZnVuY19iaXRzIChqZnVuYywgd2k6OnRvX3dpZGVzdCAo YXJnKSwgMCk7CisJICBpcmFuZ2UgJnIgPSBhc19hIDxpcmFuZ2U+ICh2cik7CisJICBpcmFuZ2Vf Yml0bWFzayBibSA9IHIuZ2V0X2JpdG1hc2sgKCk7CisJICBzaWdub3Agc2lnbiA9IFRZUEVfU0lH TiAoVFJFRV9UWVBFIChhcmcpKTsKKwkgIGlwYV9zZXRfamZ1bmNfYml0cyAoamZ1bmMsCisJCQkg ICAgICB3aWRlc3RfaW50Ojpmcm9tIChibS52YWx1ZSAoKSwgc2lnbiksCisJCQkgICAgICB3aWRl c3RfaW50Ojpmcm9tIChibS5tYXNrICgpLCBzaWduKSk7CiAJfQogICAgICAgZWxzZSBpZiAoUE9J TlRFUl9UWVBFX1AgKFRSRUVfVFlQRSAoYXJnKSkpCiAJewpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3Rz dWl0ZS9nKysuZGcvaXBhL3B1cmUtY29uc3QtMy5DIGIvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvaXBh L3B1cmUtY29uc3QtMy5DCmluZGV4IGI0YTQ2NzNlODZlLi5lNDNjZjA5YWYyNyAxMDA2NDQKLS0t IGEvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvaXBhL3B1cmUtY29uc3QtMy5DCisrKyBiL2djYy90ZXN0 c3VpdGUvZysrLmRnL2lwYS9wdXJlLWNvbnN0LTMuQwpAQCAtMSw1ICsxLDUgQEAKIC8qIHsgZGct ZG8gY29tcGlsZSB9ICovCi0vKiB7IGRnLW9wdGlvbnMgIi1PMiAtZm5vLWlwYS12cnAgLWZkdW1w LXRyZWUtb3B0aW1pemVkIC1mbm8tdHJlZS1jY3AgLWZkaXNhYmxlLXRyZWUtZXZycCIgIH0gKi8K Ky8qIHsgZGctb3B0aW9ucyAiLU8yIC1mbm8taXBhLXZycCAtZmR1bXAtdHJlZS1vcHRpbWl6ZWQg LWZuby10cmVlLWNjcCAtZmRpc2FibGUtdHJlZS1ldnJwIC1mZGlzYWJsZS10cmVlLXZycDEgLWZk aXNhYmxlLXRyZWUtdnJwMiAtZm5vLXRocmVhZC1qdW1wcyAtZm5vLXRyZWUtZG9taW5hdG9yLW9w dHMiICB9ICovCiBpbnQgKnB0cjsKIHN0YXRpYyBpbnQgYmFydmFyOwogc3RhdGljIGludCBiKGlu dCBhKTsKLS0gCjIuNDAuMQoK --------------vV5FPDnDO5v0kyKOk6YJijzh--