public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Andrew Pinski <apinski@marvell.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 6/7] Use BIT_FIELD_REF inside fold_single_bit_test
Date: Fri, 19 May 2023 22:54:16 -0600	[thread overview]
Message-ID: <bce64497-974c-6733-c191-ec26ad8388b6@gmail.com> (raw)
In-Reply-To: <20230520021451.1901275-7-apinski@marvell.com>



On 5/19/23 20:14, Andrew Pinski via Gcc-patches wrote:
> Instead of depending on combine to do the extraction,
> Let's create a tree which will expand directly into
> the extraction. This improves code generation on some
> targets.
> 
> OK? Bootstrapped and tested on x86_64-linux.
> 
> gcc/ChangeLog:
> 
> 	* expr.cc (fold_single_bit_test): Use BIT_FIELD_REF
> 	instead of shift/and.
OK.
jeff

  reply	other threads:[~2023-05-20  4:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-20  2:14 [PATCH 0/7] Improve do_store_flag Andrew Pinski
2023-05-20  2:14 ` [PATCH 1/7] Move fold_single_bit_test to expr.cc from fold-const.cc Andrew Pinski
2023-05-20  4:43   ` Jeff Law
2023-05-20  2:14 ` [PATCH 2/7] Inline and simplify fold_single_bit_test_into_sign_test into fold_single_bit_test Andrew Pinski
2023-05-20  4:47   ` Jeff Law
2023-05-20  4:48   ` Jeff Law
2023-05-20  2:14 ` [PATCH 3/7] Use get_def_for_expr in fold_single_bit_test Andrew Pinski
2023-05-20  4:49   ` Jeff Law
2023-05-20  2:14 ` [PATCH 4/7] Simplify fold_single_bit_test slightly Andrew Pinski
2023-05-20  4:51   ` Jeff Law
2023-05-20  2:14 ` [PATCH 5/7] Simplify fold_single_bit_test with respect to code Andrew Pinski
2023-05-20  4:52   ` Jeff Law
2023-05-20  2:14 ` [PATCH 6/7] Use BIT_FIELD_REF inside fold_single_bit_test Andrew Pinski
2023-05-20  4:54   ` Jeff Law [this message]
2023-05-20  2:14 ` [PATCH 7/7] Expand directly for single bit test Andrew Pinski
2023-05-20  4:55   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce64497-974c-6733-c191-ec26ad8388b6@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=apinski@marvell.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).