From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id EF61B3858C41 for ; Sat, 20 May 2023 04:54:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF61B3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1ae4be0b1f3so28965015ad.0 for ; Fri, 19 May 2023 21:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684558458; x=1687150458; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MY37lq4rEvopnDsv+yolavLsIAk+MbdZVK643anEH8A=; b=C0qDi75gJmlec0t116Ba3JEqRTfBy5IhQCz3JOXPm7anXIzDS42ikgIs4avB99TYSr znXNXxH33YQCT2u+3x9ghs2/xxsXAG0oUE4KA5jEIunKCTZohQ7k1bUvlrFwmTzQtuSr SWwYQH50npIQ8EdmCmtZAhWprlk0I5izGrx12MO3odMxSONWH/00StaCiV3v1gt8IZ0g kWr0mLDeVbbDxTCfJM5ayPfdXwOGN6E/jdhXPS7SIHqJDKawIAHbfjdwMTgxZ6CCsJtb 7+eQIhhdyePULUeGW+AYzpEUA6CCehOJpBnOeNKXFkIjdstmESqFoklkncl7w+WAV6Oc RacA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684558458; x=1687150458; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MY37lq4rEvopnDsv+yolavLsIAk+MbdZVK643anEH8A=; b=CUi/ktWLj6sdEYv2SOJuay23tm/ZIcuDKR6UbCpyVOwgTFjZzsYe9UBVATWqDd9aZX 4Gx+GLL3mCU9nDW3tGxt9hq1+0wjKTO/Jl5MYRK9Zp6lpCN0+XDIDB7iJaatchtNxfaf VQPS8rvCXttVz9TTsxgh7QJqWYxUn25yFKMC8tajL7U1nBlddC4CmBSDJm/il4Em7V5j gf5LnNMsexBgrJuvGeEHxMiNu9jq2G7fAYpMujtqRgfW+8GLxljMX41y1Ct0dExLP6CT MVpfSD+NeBTY3RP6hFRgUHMC8TPiDhRGTu8zcsuHyDZJ/eBsihRRJWWvimbOFIaxrjGg qpHA== X-Gm-Message-State: AC+VfDxZtgp9JdGZVf0B42Zq3yoXNfZDTQRMtJHY5EhWFiw1jhK+tzKG zg3shQFQ3C42MDRR8cxK/krLGTel6qS2gw== X-Google-Smtp-Source: ACHHUZ6UbyYba62mz3dntllqQgmWA4prAZ6oYt8mUChg/XFdSO63yQ5vXlwdNJW8YjrJPMq720ArTg== X-Received: by 2002:a17:903:182:b0:1ae:4ee3:e3e6 with SMTP id z2-20020a170903018200b001ae4ee3e3e6mr5247925plg.32.1684558457903; Fri, 19 May 2023 21:54:17 -0700 (PDT) Received: from ?IPV6:2601:681:8d00:265::f0a? ([2601:681:8d00:265::f0a]) by smtp.gmail.com with ESMTPSA id u5-20020a17090282c500b001aafb802efbsm504619plz.12.2023.05.19.21.54.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 21:54:17 -0700 (PDT) Message-ID: Date: Fri, 19 May 2023 22:54:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 6/7] Use BIT_FIELD_REF inside fold_single_bit_test Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230520021451.1901275-1-apinski@marvell.com> <20230520021451.1901275-7-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230520021451.1901275-7-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/19/23 20:14, Andrew Pinski via Gcc-patches wrote: > Instead of depending on combine to do the extraction, > Let's create a tree which will expand directly into > the extraction. This improves code generation on some > targets. > > OK? Bootstrapped and tested on x86_64-linux. > > gcc/ChangeLog: > > * expr.cc (fold_single_bit_test): Use BIT_FIELD_REF > instead of shift/and. OK. jeff