From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 7B5A23858C56 for ; Fri, 14 Oct 2022 10:27:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B5A23858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B8201F385; Fri, 14 Oct 2022 10:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1665743249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/6dc2Ry0hENNpbij7R2trbWSZI2ag+w/bdZCYLreP0=; b=xTIJ4lh2TgyMICZz09Dhgu/rUUwh/1pHX1B184/laz32L7uJpNjuvv3pAMXtdi1su/ubaU RRVOtSWDUHMoyDiWIRt+Wj3ui08Sol3F/bFIFKsIbYoyXvbcOtFyuE48WJKHUZhNB3z8GC hGM6BMsE0dp7Fz8yVrgi1QVxooaL6ns= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1665743249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/6dc2Ry0hENNpbij7R2trbWSZI2ag+w/bdZCYLreP0=; b=+V+d83Nf1IDQKclUfK6Q4xABjpkIQKSMUqyfRJsZGHe1/A4bq9Ilm5M/jnLPCaVXsRPACQ Vu2FtkQuRPq+AhCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 10C5B13A4A; Fri, 14 Oct 2022 10:27:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HdHSApE5SWOHQgAAMHmgww (envelope-from ); Fri, 14 Oct 2022 10:27:29 +0000 Message-ID: Date: Fri, 14 Oct 2022 12:27:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH] Fix bogus -Wstringop-overflow warning To: Richard Biener , Eric Botcazou Cc: Jeff Law , gcc-patches@gcc.gnu.org, Martin Jambor References: <3194055.aeNJFYEL58@fomalhaut> <1908968.PYKUYFuaPT@fomalhaut> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/14/22 08:12, Richard Biener wrote: > On Fri, Oct 14, 2022 at 12:54 AM Eric Botcazou via Gcc-patches > wrote: >> >>> Not a fan as it could potentially hide a real issue, but I don't really >>> have a better solution. >> >> Thanks. >> >>> I pondered suggesting "access" affect type identity, but the cases where >>> that's really important are probably better handled by the "fn spec" >>> attribute, leaving "access" strictly impacting diagnostics. >> >> I can expand a bit here, because I tried to change the "access" attribute that >> way and this badly breaks the C compiler, for example: >> >> int foo (int n, char m[1][n]); >> >> int foo (int n, char m[1][n]) {} >> >> no longer compiles with an error about different function types. > > Note in discussion with IPA folks we agreed that IPA cloning that modifies > arguments either has to remove access attributes, adjust them or refrain > from cloning. > > Martin - has anything been done to this respect? I think it's more for Martin Jambor who's the IPA specialist when it comes to parameter manipulation. Martin > > I suppose there's also a way to figure if a clone has arguments > changed in any way? > > Thanks, > Richard. > >> -- >> Eric Botcazou >> >>