From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 55D743858002 for ; Mon, 14 Nov 2022 14:24:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55D743858002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C4BC23A; Mon, 14 Nov 2022 06:24:17 -0800 (PST) Received: from [10.1.29.152] (E121495.arm.com [10.1.29.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 72CD63F73D; Mon, 14 Nov 2022 06:24:10 -0800 (PST) Content-Type: multipart/mixed; boundary="------------d6foBOuhCjRNUEFcSe4Q0OAF" Message-ID: Date: Mon, 14 Nov 2022 14:24:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 1/2] aarch64: Enable the use of LDAPR for load-acquire semantics Content-Language: en-US To: Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" Cc: Richard Earnshaw , Richard Sandiford References: <99d6b680-3f91-cb21-e314-2d0dbb0be937@arm.com> From: "Andre Vieira (lists)" In-Reply-To: X-Spam-Status: No, score=-16.2 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_LOTSOFHASH,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------d6foBOuhCjRNUEFcSe4Q0OAF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/11/2022 14:12, Kyrylo Tkachov wrote: > >> -----Original Message----- >> From: Andre Vieira (lists) >> Sent: Monday, November 14, 2022 2:09 PM >> To: Kyrylo Tkachov ; gcc-patches@gcc.gnu.org >> Cc: Richard Earnshaw ; Richard Sandiford >> >> Subject: Re: [PATCH 1/2] aarch64: Enable the use of LDAPR for load-acquire >> semantics >> >> Here is the latest version and an updated ChangeLog: >> >> 2022-11-14  Andre Vieira  >>                        Kyrylo Tkachov >> >> gcc/ChangeLog: >> >>         * config/aarch64/aarch64.h (AARCH64_ISA_RCPC): New Macro. >>         (TARGET_RCPC): New Macro. >>         * config/aarch64/atomics.md (atomic_load): Change into an >> expand. >>         (aarch64_atomic_load_rcpc): New define_insn for ldapr. >>         (aarch64_atomic_load): Rename of old define_insn for ldar. >>         * config/aarch64/iterators.md (UNSPEC_LDAP): New unspec enum >> value. >>         * doc/invoke.texi (rcpc): Ammend documentation to mention the >> effects >>         on code generation. >> >> gcc/testsuite/ChangeLog: >> >>         * gcc.target/aarch64/ldapr.c: New test. > I don't see this test in the patch? > Thanks, > Kyrill > Oops... here it is. --------------d6foBOuhCjRNUEFcSe4Q0OAF Content-Type: text/plain; charset=UTF-8; name="ldapr2.patch" Content-Disposition: attachment; filename="ldapr2.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmggYi9nY2MvY29uZmln L2FhcmNoNjQvYWFyY2g2NC5oCmluZGV4IGU2MGY5YmNlMDIzYjJjZDVlNzIzM2VlOWI4YzYx ZmM5M2MxNDk0YzIuLjUxYThhYTAyYTU4NTBkNWM3OTI1NWRiZjdlMDc2NGZmZGVjNzNjY2Qg MTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmgKKysrIGIvZ2NjL2Nv bmZpZy9hYXJjaDY0L2FhcmNoNjQuaApAQCAtMjIxLDYgKzIyMSw3IEBAIGVudW0gY2xhc3Mg YWFyY2g2NF9mZWF0dXJlIDogdW5zaWduZWQgY2hhciB7CiAjZGVmaW5lIEFBUkNINjRfSVNB X1Y5XzNBICAgICAgICAgIChhYXJjaDY0X2lzYV9mbGFncyAmIEFBUkNINjRfRkxfVjlfM0Ep CiAjZGVmaW5lIEFBUkNINjRfSVNBX01PUFMJICAgKGFhcmNoNjRfaXNhX2ZsYWdzICYgQUFS Q0g2NF9GTF9NT1BTKQogI2RlZmluZSBBQVJDSDY0X0lTQV9MUzY0CSAgIChhYXJjaDY0X2lz YV9mbGFncyAmIEFBUkNINjRfRkxfTFM2NCkKKyNkZWZpbmUgQUFSQ0g2NF9JU0FfUkNQQyAg ICAgICAgICAgKGFhcmNoNjRfaXNhX2ZsYWdzICYgQUFSQ0g2NF9GTF9SQ1BDKQogCiAvKiBD cnlwdG8gaXMgYW4gb3B0aW9uYWwgZXh0ZW5zaW9uIHRvIEFkdlNJTUQuICAqLwogI2RlZmlu ZSBUQVJHRVRfQ1JZUFRPIChBQVJDSDY0X0lTQV9DUllQVE8pCkBAIC0zMjgsNiArMzI5LDkg QEAgZW51bSBjbGFzcyBhYXJjaDY0X2ZlYXR1cmUgOiB1bnNpZ25lZCBjaGFyIHsKIC8qIFNC IGluc3RydWN0aW9uIGlzIGVuYWJsZWQgdGhyb3VnaCArc2IuICAqLwogI2RlZmluZSBUQVJH RVRfU0IgKEFBUkNINjRfSVNBX1NCKQogCisvKiBSQ1BDIGxvYWRzIGZyb20gQXJtdjguMy1h LiAgKi8KKyNkZWZpbmUgVEFSR0VUX1JDUEMgKEFBUkNINjRfSVNBX1JDUEMpCisKIC8qIEFw cGx5IHRoZSB3b3JrYXJvdW5kIGZvciBDb3J0ZXgtQTUzIGVycmF0dW0gODM1NzY5LiAgKi8K ICNkZWZpbmUgVEFSR0VUX0ZJWF9FUlJfQTUzXzgzNTc2OQlcCiAgICgoYWFyY2g2NF9maXhf YTUzX2VycjgzNTc2OSA9PSAyKQlcCmRpZmYgLS1naXQgYS9nY2MvY29uZmlnL2FhcmNoNjQv YXRvbWljcy5tZCBiL2djYy9jb25maWcvYWFyY2g2NC9hdG9taWNzLm1kCmluZGV4IGJjOTVm NmQ5ZDE1ZjE5MGEzZTMzNzA0YjRkZWYyODYwZDVmMzM5YmQuLmRjNWY1MmVlOGE0YjM0OWMw ZDg0NjZhMTYxOTZmODM2MDQ4OTNjYmIgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvYWFyY2g2 NC9hdG9taWNzLm1kCisrKyBiL2djYy9jb25maWcvYWFyY2g2NC9hdG9taWNzLm1kCkBAIC02 NTcsNyArNjU3LDM4IEBACiAgIH0KICkKIAotKGRlZmluZV9pbnNuICJhdG9taWNfbG9hZDxt b2RlPiIKKyhkZWZpbmVfZXhwYW5kICJhdG9taWNfbG9hZDxtb2RlPiIKKyAgWyhtYXRjaF9v cGVyYW5kOkFMTEkgMCAicmVnaXN0ZXJfb3BlcmFuZCIgIj1yIikKKyAgIChtYXRjaF9vcGVy YW5kOkFMTEkgMSAiYWFyY2g2NF9zeW5jX21lbW9yeV9vcGVyYW5kIiAiUSIpCisgICAobWF0 Y2hfb3BlcmFuZDpTSSAgIDIgImNvbnN0X2ludF9vcGVyYW5kIildCisgICIiCisgIHsKKyAg ICAvKiBJZiBUQVJHRVRfUkNQQyBhbmQgdGhpcyBpcyBhbiBBQ1FVSVJFIGxvYWQsIHRoZW4g ZXhwYW5kIHRvIGEgcGF0dGVybgorICAgICAgIHVzaW5nIFVOU1BFQ1ZfTERBUC4gICovCisg ICAgZW51bSBtZW1tb2RlbCBtb2RlbCA9IG1lbW1vZGVsX2Zyb21faW50IChJTlRWQUwgKG9w ZXJhbmRzWzJdKSk7CisgICAgaWYgKFRBUkdFVF9SQ1BDCisJJiYgKGlzX21tX2FjcXVpcmUg KG1vZGVsKQorCSAgICB8fCBpc19tbV9hY3FfcmVsIChtb2RlbCkpKQorICAgICAgZW1pdF9p bnNuIChnZW5fYWFyY2g2NF9hdG9taWNfbG9hZDxtb2RlPl9yY3BjIChvcGVyYW5kc1swXSwg b3BlcmFuZHNbMV0sCisJCQkJCQkgICAgIG9wZXJhbmRzWzJdKSk7CisgICAgZWxzZQorICAg ICAgZW1pdF9pbnNuIChnZW5fYWFyY2g2NF9hdG9taWNfbG9hZDxtb2RlPiAob3BlcmFuZHNb MF0sIG9wZXJhbmRzWzFdLAorCQkJCQkJb3BlcmFuZHNbMl0pKTsKKyAgICBET05FOworICB9 CispCisKKyhkZWZpbmVfaW5zbiAiYWFyY2g2NF9hdG9taWNfbG9hZDxtb2RlPl9yY3BjIgor ICBbKHNldCAobWF0Y2hfb3BlcmFuZDpBTExJIDAgInJlZ2lzdGVyX29wZXJhbmQiICI9ciIp CisgICAgKHVuc3BlY192b2xhdGlsZTpBTExJCisgICAgICBbKG1hdGNoX29wZXJhbmQ6QUxM SSAxICJhYXJjaDY0X3N5bmNfbWVtb3J5X29wZXJhbmQiICJRIikKKyAgICAgICAobWF0Y2hf b3BlcmFuZDpTSSAyICJjb25zdF9pbnRfb3BlcmFuZCIpXQkJCTs7IG1vZGVsCisgICAgICBV TlNQRUNWX0xEQVApKV0KKyAgIlRBUkdFVF9SQ1BDIgorICAibGRhcHI8YXRvbWljX3NmeD5c dCU8dz4wLCAlMSIKKykKKworKGRlZmluZV9pbnNuICJhYXJjaDY0X2F0b21pY19sb2FkPG1v ZGU+IgogICBbKHNldCAobWF0Y2hfb3BlcmFuZDpBTExJIDAgInJlZ2lzdGVyX29wZXJhbmQi ICI9ciIpCiAgICAgKHVuc3BlY192b2xhdGlsZTpBTExJCiAgICAgICBbKG1hdGNoX29wZXJh bmQ6QUxMSSAxICJhYXJjaDY0X3N5bmNfbWVtb3J5X29wZXJhbmQiICJRIikKZGlmZiAtLWdp dCBhL2djYy9jb25maWcvYWFyY2g2NC9pdGVyYXRvcnMubWQgYi9nY2MvY29uZmlnL2FhcmNo NjQvaXRlcmF0b3JzLm1kCmluZGV4IGE4YWQ0ZTVmZjIxNWFkZTA2YzNjYTEzYTI0ZWYxOGQy NTlhZmNiNmMuLmQ4YzJmOWQ2YzMyZDZmMTg4ZDU4NGMyZTlkOGZiMzY1MTE2MjRkZTYgMTAw NjQ0Ci0tLSBhL2djYy9jb25maWcvYWFyY2g2NC9pdGVyYXRvcnMubWQKKysrIGIvZ2NjL2Nv bmZpZy9hYXJjaDY0L2l0ZXJhdG9ycy5tZApAQCAtOTg4LDYgKzk4OCw3IEBACiAgICAgVU5T UEVDVl9MWAkJCTsgUmVwcmVzZW50IGEgbG9hZC1leGNsdXNpdmUuCiAgICAgVU5TUEVDVl9T WAkJCTsgUmVwcmVzZW50IGEgc3RvcmUtZXhjbHVzaXZlLgogICAgIFVOU1BFQ1ZfTERBCQkJ OyBSZXByZXNlbnQgYW4gYXRvbWljIGxvYWQgb3IgbG9hZC1hY3F1aXJlLgorICAgIFVOU1BF Q1ZfTERBUAkJOyBSZXByZXNlbnQgYW4gYXRvbWljIGFjcXVpcmUgbG9hZCB3aXRoIFJDcGMg c2VtYW50aWNzLgogICAgIFVOU1BFQ1ZfU1RMCQkJOyBSZXByZXNlbnQgYW4gYXRvbWljIHN0 b3JlIG9yIHN0b3JlLXJlbGVhc2UuCiAgICAgVU5TUEVDVl9BVE9NSUNfQ01QU1cJOyBSZXBy ZXNlbnQgYW4gYXRvbWljIGNvbXBhcmUgc3dhcC4KICAgICBVTlNQRUNWX0FUT01JQ19FWENI Rwk7IFJlcHJlc2VudCBhbiBhdG9taWMgZXhjaGFuZ2UuCmRpZmYgLS1naXQgYS9nY2MvZG9j L2ludm9rZS50ZXhpIGIvZ2NjL2RvYy9pbnZva2UudGV4aQppbmRleCA0NDlkZjU5NzI5ODg0 YWEzMjkyNTU5ZmZmY2ZiYmNjOTkxODJjMTNhLi41YTMyZDdiNmU5NDUwMmM1N2U2NDM4Y2Zk MjU2M2JjNTYzMTY5MGUxIDEwMDY0NAotLS0gYS9nY2MvZG9jL2ludm9rZS50ZXhpCisrKyBi L2djYy9kb2MvaW52b2tlLnRleGkKQEAgLTIwMTY4LDkgKzIwMTY4LDkgQEAgRW5hYmxlIEZQ MTYgZm1sYSBleHRlbnNpb24uICBUaGlzIGFsc28gZW5hYmxlcyBGUDE2IGV4dGVuc2lvbnMg YW5kCiBmbG9hdGluZy1wb2ludCBpbnN0cnVjdGlvbnMuIFRoaXMgb3B0aW9uIGlzIGVuYWJs ZWQgYnkgZGVmYXVsdCBmb3IgQG9wdGlvbnstbWFyY2g9YXJtdjguNC1hfS4gVXNlIG9mIHRo aXMgb3B0aW9uIHdpdGggYXJjaGl0ZWN0dXJlcyBwcmlvciB0byBBcm12OC4yLUEgaXMgbm90 IHN1cHBvcnRlZC4KIAogQGl0ZW0gcmNwYwotRW5hYmxlIHRoZSBSY1BjIGV4dGVuc2lvbi4g IFRoaXMgZG9lcyBub3QgY2hhbmdlIGNvZGUgZ2VuZXJhdGlvbiBmcm9tIEdDQywKLWJ1dCBp cyBwYXNzZWQgb24gdG8gdGhlIGFzc2VtYmxlciwgZW5hYmxpbmcgaW5saW5lIGFzbSBzdGF0 ZW1lbnRzIHRvIHVzZQotaW5zdHJ1Y3Rpb25zIGZyb20gdGhlIFJjUGMgZXh0ZW5zaW9uLgor RW5hYmxlIHRoZSBSQ3BjIGV4dGVuc2lvbi4gIFRoaXMgZW5hYmxlcyB0aGUgdXNlIG9mIHRo ZSBMREFQUiBpbnN0cnVjdGlvbnMgZm9yCitsb2FkLWFjcXVpcmUgYXRvbWljIHNlbWFudGlj cywgYW5kIHBhc3NlcyBpdCBvbiB0byB0aGUgYXNzZW1ibGVyLCBlbmFibGluZworaW5saW5l IGFzbSBzdGF0ZW1lbnRzIHRvIHVzZSBpbnN0cnVjdGlvbnMgZnJvbSB0aGUgUkNwYyBleHRl bnNpb24uCiBAaXRlbSBkb3Rwcm9kCiBFbmFibGUgdGhlIERvdCBQcm9kdWN0IGV4dGVuc2lv bi4gIFRoaXMgYWxzbyBlbmFibGVzIEFkdmFuY2VkIFNJTUQgaW5zdHJ1Y3Rpb25zLgogQGl0 ZW0gYWVzCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9s ZGFwci5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNoNjQvbGRhcHIuYwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4yMWY2NDY0YzYwZTBjMTIzOTM4NWZiM2EzNjZmOWY5Zjg0YjNjYWRmCi0t LSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNoNjQvbGRh cHIuYwpAQCAtMCwwICsxLDM0IEBACisvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLworLyogeyBk Zy1vcHRpb25zICItTzEgLXN0ZD1jOTkiIH0gKi8KKyNpbmNsdWRlIDxzdGRhdG9taWMuaD4K KworI3ByYWdtYSBHQ0MgdGFyZ2V0ICIrcmNwYyIKK2F0b21pY191bGxvbmcgdTY0OworYXRv bWljX2xsb25nIHM2NDsKK2F0b21pY191aW50IHUzMjsKK2F0b21pY19pbnQgczMyOworYXRv bWljX3VzaG9ydCB1MTY7CithdG9taWNfc2hvcnQgczE2OworYXRvbWljX3VjaGFyIHU4Owor YXRvbWljX3NjaGFyIHM4OworCisjZGVmaW5lIFRFU1Qoc2l6ZSwgcmV0dHlwZSkJCQkJCVwK K3JldHR5cGUJCQkJCQkJCVwKK3Rlc3RfIyNzaXplICh2b2lkKQkJCQkJCVwKK3sJCQkJCQkJ CVwKKyAgcmV0dXJuIGF0b21pY19sb2FkX2V4cGxpY2l0ICgmc2l6ZSwgbWVtb3J5X29yZGVy X2FjcXVpcmUpOwlcCit9CQkJCQkJCQlcCisKK1RFU1QodTY0LCB1bnNpZ25lZCBsb25nIGxv bmcpCitURVNUKHM2NCwgbG9uZyBsb25nKQorVEVTVCh1MzIsIHVuc2lnbmVkIGludCkKK1RF U1QoczMyLCBpbnQpCitURVNUKHUxNiwgdW5zaWduZWQgc2hvcnQpCitURVNUKHMxNiwgc2hv cnQpCitURVNUKHU4LCB1bnNpZ25lZCBjaGFyKQorVEVTVChzOCwgc2lnbmVkIGNoYXIpCisK Ky8qIHsgZGctZmluYWwgeyBzY2FuLWFzc2VtYmxlci10aW1lcyAibGRhcHJcdHgiIDIgfSB9 ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1hc3NlbWJsZXItdGltZXMgImxkYXByXHR3IiAy IH0gfSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tYXNzZW1ibGVyLXRpbWVzICJsZGFwcmhc dHciIDIgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1hc3NlbWJsZXItdGltZXMgImxk YXByYlx0dyIgMiB9IH0gKi8K --------------d6foBOuhCjRNUEFcSe4Q0OAF--