Re: [PATCH] c++/modules: inline namespace abi_tag streaming [PR110730]

[Jason Merrill <jason@redhat.com>]

On 3/6/24 14:10, Patrick Palka wrote:
> Tested on x86_64-pc-linux-gnu, does this look OK for trunk?
> 
> -- >8 --
> 
> The unreduced testcase from this PR crashes at runtime ultimately
> because we don't stream the abi_tag attribute on inline namespaces and
> so the filesystem::current_path() call resolves to the non-C++11 ABI
> version even though the C++11 ABI is active, leading to a crash when
> destructing the call result (which contains an std::string member).
> 
> While we do stream the DECL_ATTRIBUTES of all decls that go through
> the generic tree streaming routines, it seems namespaces are streamed
> separately from other decls and we don't use the generic routines for
> them.  So this patch makes us stream the abi_tag manually for (inline)
> namespaces.

Why not stream all DECL_ATTRIBUTES of all namespaces?

Jason