From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5DC663858D35 for ; Thu, 7 Mar 2024 01:31:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DC663858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5DC663858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709775112; cv=none; b=nhbA/IH31/yrF6TIoMMkhbB1/BAFY5c9JMS3/XrosdtF055xegqpjKJdHqMpY19onXsXsaPTdUdmwCuJkB8tl1+pmlSh/DGo75I6DrhOjJGKg5yl0Ik69w2q48R9wfyjqt8tobGgl38MevbgLEHZzs+tp/Co/iW2fbs+dRe5wtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709775112; c=relaxed/simple; bh=pafhYe8Kf1H7eL8ydS+VOjdo7lH3Ovha9siDtn/Mjt4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jhnnBzgMuN7YnQD/F+osXWmYWdTmtcozZDQfNeY2DdqP5wZr45dczAbG1M97rvEHYqEgVIWbzw0+0kjlckY8A8XBAzhPfv0Kr/vN/EGTIUUBFd1MBvvytEI23O9xGYNL4jAiI2YdIu77xbEwmPSG7euUc7fUFDzWaz/2yWQLPJQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709775110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sTmpj2tbGY32/a6NkJJd9Xdu4yaNsWSGzPdONFAZJEM=; b=eSX2T8rcI6siiy8mOpmxuZuin925aN1diVtwi3D9tr0tw4VnQ8N6CCmoqPpt9aeLbf90L4 VwkNyeHMi56ykaJOeY9essoPmNcqlNmJK/14Zk8ehLcK91+Gs5S/FIMM59F/KzfHvNlNuG o7qWp6K1gzNZxtgEtM+pu8RelD2CKZ8= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-ky0uEmJONz-Qbmlj6fNLAg-1; Wed, 06 Mar 2024 20:31:47 -0500 X-MC-Unique: ky0uEmJONz-Qbmlj6fNLAg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-69066d3ceecso5986036d6.0 for ; Wed, 06 Mar 2024 17:31:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775107; x=1710379907; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sTmpj2tbGY32/a6NkJJd9Xdu4yaNsWSGzPdONFAZJEM=; b=bYG+G0cE+4vM+7CRMWe6kXTSlEofhHBi/NDgx8oaIUHfiN4VxqENwdZrz9G9uV4hML qS2R6q9GO3bqaiOyzA89wTkNIh5ZFu4iBSddCm4you2D9VIT1t65HWHHq0nEUWMGurt9 IAzctHShbtcFmNFUUwGzsZM1LFjR1hegz+2kkadGUU6Qv5qxqv2gB/9fSXPd7iRY4Z7f 887wOYhUHhoAqo+3uPTK3kc65CF4zDNWNb/vXu/dUB9+b3c/yVuivXGETG6h50Y30v9Y pR3BLOZpK0D+TafHHozUqr6kS4XLr8Nj38jl3cDs4SPd9U7zHOsicrcaE9u2Ome6bpyY 4muQ== X-Forwarded-Encrypted: i=1; AJvYcCVjNzdafLO6znjU3BvJ33uoiFKDce9DEspIt/AX5Wtm4OdErwjDsUiB94vq3MoVyMVkOn39cg2KkAE4/WJHck7g5HV6i8NhSg== X-Gm-Message-State: AOJu0Yzh9V6DyWBaR/ggNPrZCYmuiwMkaxSOPdPladgvq5D3H+M0RCpG mLPxu21AvPCl8HD82qK+2dI+pYw6KBlDXIh6FZ+OjxUhXJ0Qya1L/TGQBbfqkkYk1rV3SfLJrz7 qmWJC6VL4sXaFV/MO5jRaeSHzSW3ALFTJz+hmVxFzHkchMc00HDOskAE= X-Received: by 2002:a0c:ea31:0:b0:690:9274:9ec9 with SMTP id t17-20020a0cea31000000b0069092749ec9mr4229201qvp.19.1709775107136; Wed, 06 Mar 2024 17:31:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6HvKiitlmd4DqXb/oTeK5Zxq1Pyiojf9ebJ7DZz8VZb99VIZBGSjZzYAB2evW6+0GALhT/w== X-Received: by 2002:a0c:ea31:0:b0:690:9274:9ec9 with SMTP id t17-20020a0cea31000000b0069092749ec9mr4229190qvp.19.1709775106816; Wed, 06 Mar 2024 17:31:46 -0800 (PST) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id y17-20020a0cead1000000b0069051255b1bsm4921372qvp.77.2024.03.06.17.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 17:31:46 -0800 (PST) Message-ID: Date: Wed, 6 Mar 2024 20:31:45 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++/modules: inline namespace abi_tag streaming [PR110730] To: Patrick Palka , gcc-patches@gcc.gnu.org Cc: nathan@acm.org References: <20240306191042.1883372-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20240306191042.1883372-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/6/24 14:10, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > -- >8 -- > > The unreduced testcase from this PR crashes at runtime ultimately > because we don't stream the abi_tag attribute on inline namespaces and > so the filesystem::current_path() call resolves to the non-C++11 ABI > version even though the C++11 ABI is active, leading to a crash when > destructing the call result (which contains an std::string member). > > While we do stream the DECL_ATTRIBUTES of all decls that go through > the generic tree streaming routines, it seems namespaces are streamed > separately from other decls and we don't use the generic routines for > them. So this patch makes us stream the abi_tag manually for (inline) > namespaces. Why not stream all DECL_ATTRIBUTES of all namespaces? Jason