From: Daniel Santos <daniel.santos@pobox.com>
To: Ian Lance Taylor <iant@google.com>
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] [i386] Recompute the frame layout less often
Date: Tue, 16 May 2017 21:35:00 -0000 [thread overview]
Message-ID: <bd57963c-868a-47c0-8805-caf654510764@pobox.com> (raw)
In-Reply-To: <CAKOQZ8x4DipCMP2iNP756CGLQOkivOrKko00AgPWrhHXH-Q6bg@mail.gmail.com>
On 05/16/2017 12:19 PM, Ian Lance Taylor wrote:
> On Mon, May 15, 2017 at 10:00 PM, Daniel Santos <daniel.santos@pobox.com> wrote:
>> Ian, would you mind looking at this please? A combination of my
>> -mcall-ms2sysv-xlogues patch with Bernd's patch is causing problems when
>> ix86_expand_split_stack_prologue() calls ix86_expand_call().
> I don't have a lot of context here. I assume that ms2sysv is going to
> be used on Windows systems, where -fsplit-stack isn't really going to
> work anyhow, so I think it would probably be OK that reject that
> combination if it causes trouble.
Sorry I wasn't more specific. This -mcall-ms2sysv-xlogues actually
targets Wine, although they don't use -fsplit-stack. My patch set as-is
is disabled when fsplit-stack is used, but during
ix86_compute_frame_layout, which is too late in the case of
-fsplit-stack. I think I should just change this to a sorry() in
ix86_option_override_internal.
> Also, it's overkill for ix86_expand_split_stack_prologue to call
> ix86_expand_call. The call is always to __morestack, and __morestack
> is written in assembler, so we could use a simpler version of
> ix86_expand_call if that helps. In particular we can decide that
> __morestack doesn't clobber any unusual registers, if that is what is
> causing the problem.
>
> Ian
Well aside from the conflict of the two patches, it just looks like it
has the potential to generate clobbers where none are needed, but I'm
having trouble actually *proving* that, so maybe I'm just wrong.
Daniel
next prev parent reply other threads:[~2017-05-16 21:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 9:11 Bernd Edlinger
2017-05-14 9:58 ` Daniel Santos
2017-05-14 10:27 ` Uros Bizjak
2017-05-14 18:11 ` Bernd Edlinger
2017-05-14 20:37 ` Daniel Santos
2017-05-15 2:23 ` Daniel Santos
2017-05-15 20:41 ` Bernd Edlinger
2017-05-15 23:52 ` Daniel Santos
2017-05-16 5:42 ` Daniel Santos
2017-05-16 8:52 ` Bernd Edlinger
2017-05-16 15:11 ` Daniel Santos
2017-05-16 17:38 ` Ian Lance Taylor via gcc-patches
2017-05-16 20:10 ` Bernd Edlinger
2017-05-16 21:05 ` Bernd Edlinger
2017-05-17 2:12 ` Daniel Santos
2017-05-17 17:43 ` Bernd Edlinger
2017-05-18 7:05 ` Daniel Santos
2017-05-18 13:48 ` Bernd Edlinger
2017-05-19 3:13 ` Daniel Santos
2017-05-22 18:32 ` Bernd Edlinger
2017-05-23 14:34 ` Bernd Edlinger
2017-05-24 6:49 ` Daniel Santos
2017-06-01 16:06 ` [PING][PATCH] " Bernd Edlinger
2017-06-01 18:18 ` [PATCH] " Uros Bizjak
2017-05-23 23:01 ` Daniel Santos
2017-05-16 21:35 ` Daniel Santos [this message]
2017-05-17 18:41 ` Bernd Edlinger
2017-05-18 7:14 ` Daniel Santos
2017-05-19 5:12 ` Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd57963c-868a-47c0-8805-caf654510764@pobox.com \
--to=daniel.santos@pobox.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).