From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A45B43882AF8; Tue, 18 Jun 2024 19:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A45B43882AF8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A45B43882AF8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718737386; cv=none; b=RG6hK9S5iBBko1u0HGuBzQ+JNeAo8qXZczK5uJRF2mz/l41TIhGaNNFtnQM0pkWrOba/SBu8Zlzz30r6BkT8LZtkDx3KvIwQNqdlpp0BGMdMl5sdzjUyA3QXqq6OEpBRdH62UkwItD3NOIZAarQOHo3IDv//t16+5phD7acKv3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718737386; c=relaxed/simple; bh=+HoVg6bY8dEzhNYUxgfRfDLYYdnERgdZ/c3bxjfXOcA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sSfH1ISyRYIZW2yjmeIxC/R8ykiEckOQbMZD2T2rpzySNFFgcUdsg1Tr7EbbE0BlQPSfhyZL32oxBxEMdL4vwSgCgws1A1+Ow6rZr2ka/S9haLKDMIM1yolwla7Gz/MnuZaVs5KjH7/JG4qZW3MYTRcM0942F2CCFanvDP2qVKI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45IIxJJD005004; Tue, 18 Jun 2024 19:03:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=/ J5FTsn4o+j05ckS1BFmWvanMs7Nvjpuahs657e41Ts=; b=JePn0FtqDRMNKDtil IL4B7Nkrp46SKrAL2D0dYv3o+P6xWtjUoTlINAr2yJVfRVpLTmuSaHlXB1NGnNPA sQ2iytk7NOerioGFFz6et9OxrIIrznEf6XzBhbCgmCzKi/cViNVFYMOQzH4SpTfs Kl9gXBFhIyTRiAs3D/8wuS9roWsTAyXCT7zuFpUZt2p8OwXn3O6sGyH4/JLmUKz1 TiGg8BySiC8Xf/aNQEFxb/U1RjOK54SdBIYvtxmm9u8OvXupvzuT2RoR6NrHUdFL TAvnRISjZjTxeePb5S1AKsTRcBworsCNMlkNaaxbJXIaeuoQs87SgmKKu6FEYd+m S9mOw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yufyy80ax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jun 2024 19:03:02 +0000 (GMT) Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45IJ31UK010688; Tue, 18 Jun 2024 19:03:02 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yufyy80aq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jun 2024 19:03:01 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45IH9gl3011027; Tue, 18 Jun 2024 19:03:00 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yspsn5wpx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jun 2024 19:03:00 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45IJ2vlB29491962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Jun 2024 19:02:59 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E60F58054; Tue, 18 Jun 2024 19:02:57 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73EA158056; Tue, 18 Jun 2024 19:02:56 +0000 (GMT) Received: from [9.61.45.213] (unknown [9.61.45.213]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 18 Jun 2024 19:02:56 +0000 (GMT) Message-ID: Date: Tue, 18 Jun 2024 14:02:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] rs6000: Fix incorrect RTL for Power LE when removing the UNSPECS [PR106069] To: "Kewen.Lin" , Xionghu Luo Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, guojiufu@linux.ibm.com, linkw@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <20230210025952.1887696-1-xionghuluo@tencent.com> <9564021b-80d0-7eb8-e84b-1918d0718893@linux.ibm.com> Content-Language: en-US From: Peter Bergner In-Reply-To: <9564021b-80d0-7eb8-e84b-1918d0718893@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: V88qEn6Zf09FP1GpfbBkbVQwbbEuvQ1t X-Proofpoint-GUID: pWJjHY_ElKnMpWPZTSVSwQ6edIe9ZVCE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-18_02,2024-06-17_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 malwarescore=0 clxscore=1011 mlxscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406180140 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/12/24 2:50 AM, Kewen.Lin wrote: > As the recent PR115355 shows, this issue can also affect the > behavior when users are adopting vectorization optimization, > IMHO we should get this landed as soon as possible. I agree we want this fixed ASAP. > As all said above, I believe this patch is a correct fix and > considering the impact of the issue, I'd like to get this > pushed next week if no objections. The only complaint I have on the patch, and I know this existed before the patch, is we're using register_operand for the predicate for these patterns when we probably should be using altivec_register_operand or vsx_register_operand depending on the specific pattern. Yes, other pre-existing patterns use that, but those should probably be fixed too. Maybe we go with register_operand for now with this patch and then have a follow-on patch (from us) that cleans those all up??? Otherwise, LGTM (although I can't approve it). Peter