From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16159 invoked by alias); 5 Dec 2019 15:40:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16143 invoked by uid 89); 5 Dec 2019 15:40:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 15:40:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575560401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KrT8z8poshWJUbEr6YdKSNYd9JKOZvErrkMHXvGKf1c=; b=N49ESSCiPCFXg5J+I002CZtH+ng8Yucf3O3DmkoyI1AtMLG+1eiTWxlStBXP7CNFLAz3GR 2Zt7Z0Pr8EPHND7Vm3kSgm8zPXaASVW0bXwRywij7HwiL/ggnQkZDFDdCV5K0cdqBMsPYW rr0trZABR0MXXLl2xTCmF2eP8bC4EzQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-H2HTd1MSPSiU2Ui5XeBCGQ-1; Thu, 05 Dec 2019 10:39:57 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8AEC4DB23; Thu, 5 Dec 2019 15:39:56 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-27.phx2.redhat.com [10.3.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 569E95D6A5; Thu, 5 Dec 2019 15:39:54 +0000 (UTC) Subject: Re: [PATCH] PR85678: Change default to -fno-common To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Wilco Dijkstra , GCC Patches References: <2600d107-dc05-95b0-8864-5a9c4d7bb85e@suse.cz> <80b78a44-0983-fcee-0125-bca5140618a4@redhat.com> <8d02a9f7-48cf-1974-a149-d00f05204e31@redhat.com> From: Jeff Law Message-ID: Date: Thu, 05 Dec 2019 15:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00333.txt.bz2 On 12/5/19 2:16 AM, Martin Li=9Aka wrote: >=20 >> >> Of the ~450 packages affected I'd estimate that even with the opt-out >> mechanism we're still going to have to fix ~100 packages immediately >> because they don't honor the flags injection mechanisms which the >> opt-out approach relies upon. >=20 > Fortunately, we switch at openSUSE to use -fpie by default and our packag= es > honor the flags ;) :-) Fedora is in much worse shape than RHEL simply because we haven't pushed hard on the injection issues for Fedora and because there's a ton of stuff in Fedora that isn't in RHEL. So it looks like ~150 packages in Fedora that are affected by the -fno-common change and which aren't honoring the flags injection. Not great, but probably manageable. >=20 > I would like to mention here that key work is to report and explain that > to upstream. Only that will help for the future to reduce number of > packages > that will need the -fcommon option. That's the biggest effort in my > opinion. Absolutely. I've found this takes more time than fixing the issue in the first place on other stuff and I'd expect it to be no different than the -fno-common stuff. jeff