From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 41DBD3858C50 for ; Tue, 22 Nov 2022 09:04:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41DBD3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669107874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdHTxfj6UwqioljcRciyLwVqw97BcgsTaFFSBpPG1ww=; b=V9tM6oioGDgDfGN3ueMrqTAnnK2JLkS9PCZoTksfdSekSGFSO8oSDU3UJZsxaZUa5SvvrF 1pDD0fvLav4p3mmfj7E0OjiHUAX93pFE9CFrU9Ko6PVvHbaRhUvRdY+fNUsH27xtKm+MCK G2HUd+E+P+fxTq8Yc4cD8d2pD93ZGg0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-64-dXcMGGWRPnuG473GnkNXrw-1; Tue, 22 Nov 2022 04:04:33 -0500 X-MC-Unique: dXcMGGWRPnuG473GnkNXrw-1 Received: by mail-wm1-f71.google.com with SMTP id f1-20020a1cc901000000b003cf703a4f08so3843321wmb.2 for ; Tue, 22 Nov 2022 01:04:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mdHTxfj6UwqioljcRciyLwVqw97BcgsTaFFSBpPG1ww=; b=QtEeqlJRwWRB/4mB2Mo4qa50vq9P6Psk5H5IcaYfylIqtUhvC8rtOgQLVuJbhfKLJy xNljxr0kVSUVcTFHCGczYxRXU31OxskPzMKYTVpKt2xJE/ht9PHtuTkCO7SmXTe6HhL6 dps362wnaIOq3brn/ql30oQnZtATbOenuFcp1IOx+vR3k6BQsnzE/mkcVasvtGrh3y32 aYRnNc+DQjpDwUAdrs8vri711emtApegV6UXFSa9Zie8oAPOzkPFM0ePv6H8I3oaZkH0 NcBpw2Pi+3wCtksGDd8jVHwS9QtRpn7+s74Og/gf6DKHvWXhO/tNDGzzydZQGr9kN0d+ yprw== X-Gm-Message-State: ANoB5pmxo5O2qpkKDP2n6b8bvG2OgVhDnNrFpj7C0WYdjykfRzMtmsUS o9a7WoYb+rnYaH40ACvJ9KPr1hDtPgfpQZgMU2V4tENzPcpwtiNjUSz78U26Wi5zQcDJwryIs/L Kuw57dwTfrsrc3vLabw== X-Received: by 2002:a5d:5233:0:b0:241:cc24:b65c with SMTP id i19-20020a5d5233000000b00241cc24b65cmr7436563wra.545.1669107872405; Tue, 22 Nov 2022 01:04:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf5imdEJcJZ5cGMj8HQULqIvAABc4oYAfav2A6P+WmoIQa9IXmK4KSUjFhetShnEPvc3PB8Pxw== X-Received: by 2002:a5d:5233:0:b0:241:cc24:b65c with SMTP id i19-20020a5d5233000000b00241cc24b65cmr7436545wra.545.1669107872150; Tue, 22 Nov 2022 01:04:32 -0800 (PST) Received: from [192.168.1.2] ([139.47.35.255]) by smtp.gmail.com with ESMTPSA id a6-20020adffb86000000b0022cdeba3f83sm13440689wrr.84.2022.11.22.01.04.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 01:04:31 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 10:04:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Remove legacy VRP (maybe?) To: Richard Biener , Jeff Law Cc: Jakub Jelinek , "MacLeod, Andrew" , gcc-patches References: <2eb36356-ffbf-6c8b-2824-08e204280d52@gmail.com> From: Aldy Hernandez In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/22/22 09:25, Richard Biener wrote: > On Tue, Nov 22, 2022 at 9:24 AM Richard Biener > wrote: >> >> On Mon, Nov 21, 2022 at 5:49 PM Jeff Law wrote: >>> >>> >>> On 11/21/22 09:35, Aldy Hernandez via Gcc-patches wrote: >>>> I've been playing around with removing the legacy VRP code for the >>>> next release. It's a layered onion to get this right, but the first >>>> bit is pretty straightforward and may be useful for this release. >>>> Basically, it entails removing the old VRP pass itself, along with >>>> value_range_equiv which have no producers left. The current users of >>>> value_range_equiv don't put anything in the equivalence bitmaps, so >>>> they're basically behaving like plain value_range. >>>> >>>> I removed as much as possible without having to change any behavior, >>>> and this is what I came up with. Is this something that would be >>>> useful for this release? Would it help release managers have less >>>> unused cruft in the tree? >>>> >>>> Neither Andrew nor I have any strong feelings here. We don't foresee >>>> the legacy code changing at all in the offseason, so we can just >>>> accumulate these patches in local trees. >>> >>> I'd lean towards removal after gcc-13 releases. >> >> I think removing the ability to switch to the old implementation easens >> maintainance so I'd prefer to have this before the gcc-13 release. >> >> So please go ahead. > > Btw, ASSERT_EXPR should also go away with this, no? Ah yes, for everything except ipa-*.* which uses it internally (and sets it in its internal structures): - ASSERT_EXPR means that only the value in operand is allowed to pass through (without any change), for all other values the result is unknown. I can remove all other uses, including any externally visible documentation. Thanks. Aldy