From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 5D2C93858D37 for ; Wed, 2 Mar 2022 18:59:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D2C93858D37 Received: by mail-pj1-x102f.google.com with SMTP id z12-20020a17090ad78c00b001bf022b69d6so1520049pju.2 for ; Wed, 02 Mar 2022 10:59:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Wl1fmHOnrtnw0X+ThIIx1zRrqm687577eTmjuwaNcwo=; b=7u7FtdqLwTI1ysId1PlppVJE+xF9uTj9IGwVuG93hdYeh7wCflNEuIGSds188hhTQ8 ICB2XVuBJk5EWrgFJpuVCTnlj+qfmR3aFEG7MtbZQ2KbiZDPEVGdXRZ7fLlAoeteFyxR sb58UPYgc2Hm7xdW0WPboYMD6SYxLGj1n39DsMpIciHLGxMaE4DAXgMIEzSY8MTHplNA CBTxMitcJdpmxQvUr8j3a5w+nADAnKSiKSFsFWMVvGON0zgQMaJhgKr5iqog+fzw9bg3 NCAQDea/TV7iJUARTCjB8REcWrDsPl/E9M3ls/8EnqQ27qA9+FyfBgCwWjXh8FOi0b2D DddQ== X-Gm-Message-State: AOAM530+tTxgC7X7zSIqzTBaABe6jwL5DLxqej2i1mleDxDFwAwrkCtz Kkus1NiXeuUCkagH1xPCdfo= X-Google-Smtp-Source: ABdhPJyCTVOIDj7o49vBqaQ282MiiqVTUb7NNyQToLaXANlP9sJOEsvk/cOGAJyAxV/H8Jp1FBbi/A== X-Received: by 2002:a17:90a:ce08:b0:1bc:16cb:343d with SMTP id f8-20020a17090ace0800b001bc16cb343dmr1257471pju.158.1646247576156; Wed, 02 Mar 2022 10:59:36 -0800 (PST) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id pi16-20020a17090b1e5000b001bd1ffaf2basm6028447pjb.0.2022.03.02.10.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 10:59:35 -0800 (PST) Message-ID: Date: Wed, 2 Mar 2022 11:59:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: Patch ping Content-Language: en-US To: Jakub Jelinek , Richard Biener Cc: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_LINKBAIT3, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 18:59:38 -0000 On 3/2/2022 2:47 AM, Jakub Jelinek wrote: > Hi! > > I'd like to ping the > > https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590526.html > PR104558 - when bypassing emit_push_insn for 0 sized arg, emit at least anti_adjust_stack for alignment pad if needed > > patch. So the issue is the stack isn't aligned to the pad, thus triggering the abort.  Right?  Assuming that's the case, the patch is OK with a suitable comment. Jeff