From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 44181385C406; Mon, 21 Jun 2021 12:37:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 44181385C406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 7HTpU7lnWu31979za+KVxVrvQw3UaXMYiFrGiKjhAV5W7bVQWIVPyRCfjDnC207t+W5i1vlrqM ZJLw6hCVqmbK9RQ41MtqmqYUMJPkbFv4o878vHWAKcxlQ09lo6bLNJD73MsBk4tibw3cdkfqgA QGlZyrHCuW4eHnCzJm7AXyTy6Qdt42voKbWbPOy8nkqRT1RjUUgWI9xC990BCJSviHmZyKCRsO /ay73FkuyO87K/UmkBU9TMZDCVdUzVG4xJvLS6RNtR8WIAwMKQwZqaQXsXuoD4ArrCTVlplPBg cR8= X-IronPort-AV: E=Sophos;i="5.83,289,1616486400"; d="scan'208";a="62815788" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 21 Jun 2021 04:37:49 -0800 IronPort-SDR: fR01+iyd117XzQkgCHKMh+CDkjkNpfoF1sufTDlAxnj3ulkgpVnptS2bEDeVe1aFno/ea48gwf 5l3TVWnPwOhMaBSL8GRwNB0fn6Zr0R85TxEGlBkjLPHZyWa0Ww0kF0DRw0aenmqz365pJiPEsE Zui2I87+MJx0lBwFcuSgtG8sDqB/5vTqeQPfCcQGWZId2G3syeoQyKbyMhEp/9oK5zR8OqoJML 45k1LrFqZggql+Qd1vyRNFqtT/0JeU22RS/ly0NoVUvajSp/BBZfsHvF4YIaIue+wWrv7ykToI y4c= Subject: Re: [Patch, fortran V3] PR fortran/100683 - Array initialization refuses valid To: =?UTF-8?Q?Jos=c3=a9_Rui_Faustino_de_Sousa?= , , References: From: Tobias Burnus Message-ID: Date: Mon, 21 Jun 2021 14:37:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 12:37:51 -0000 Hi Jos=C3=A9, On 17.06.21 21:34, Jos=C3=A9 Rui Faustino de Sousa via Gcc-patches wrote: > Update to a proposed patch to: > PR100683 - Array initialization refuses valid > due to more errors being found... > > Patch tested only on x86_64-pc-linux-gnu. LGTM =E2=80=93 sorry for the very belated review. > Add call to simplify expression before parsing Nit: I think you mean resolving/processing/expanding/checking =E2=80=93 as gfc_resolve_expr comes after the actual parsing. > *and* check *appropriately* if the expression is still an array after > simplification. * * * I have to admit that I got a bit lost with your patches. Are there still outstanding patches? I also recall approving a patch quite some time ago which was then not committed for a long time. (I have not checked whether it was committed by now.) Thus: Do you have a list of patches pending review? Secondly, I assume you can commit or do you have commit issues? Tobias > Fortran: Fix bogus error > > gcc/fortran/ChangeLog: > > PR fortran/100683 > * resolve.c (gfc_resolve_expr): Add call to gfc_simplify_expr. > > gcc/testsuite/ChangeLog: > > PR fortran/100683 > * gfortran.dg/pr87993.f90: increased test coverage. > * gfortran.dg/PR100683.f90: New test. ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf