From: Tobias Burnus <tobias@codesourcery.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: *PING* – Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic
Date: Fri, 06 Dec 2019 08:02:00 -0000 [thread overview]
Message-ID: <bde6fa5f-7261-78e9-1862-a45bf3729d52@codesourcery.com> (raw)
In-Reply-To: <2f70a48d-ba2e-bc37-314b-7758a9ac1e0a@codesourcery.com>
*Ping*
Regarding Frederik's remark about the testsuite:
I think the only test case in gfortran.dg/, which tests the column
number, is use_without_only_1.f90. It has:
{ dg-warning "7:has no ONLY qualifier" }
here, the "7" is the column number. — Hence, it is not surprising that
changes do not affect the test suite.
Cheers,
Tobias
On 12/4/19 2:37 PM, Tobias Burnus wrote:
> As reported internally by Frederik, gfortran currently passes
> LOCATION_COLUMN == 0 to the middle end. The reason for that is how
> parsing works – gfortran reads the input line by line.
>
> For internal error diagnostic (fortran/error.c), the column location
> was corrected – but not for locations passed to the middle end.
> Hence, the diagnostic there wasn't optimal.
>
> Fixed by introducing a new function; now one only needs to make sure
> that no new code will re-introduce "lb->location" :-)
>
> Build and regtested on x86-64-gnu-linux.
> OK for the trunk?
>
> Tobias
>
next prev parent reply other threads:[~2019-12-06 8:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 13:38 Tobias Burnus
2019-12-04 14:30 ` Harwath, Frederik
2019-12-06 8:02 ` Tobias Burnus [this message]
2019-12-06 16:42 ` *PING* – " Janne Blomqvist
2019-12-09 15:58 ` [PATCH] Fix column information for omp_clauses in Fortran code Harwath, Frederik
2019-12-09 16:03 ` Tobias Burnus
2019-12-10 14:23 ` [PATCH 0/2] Add tests to verify OpenACC clause locations Frederik Harwath
2019-12-10 14:44 ` Thomas Schwinge
2019-12-10 15:12 ` Harwath, Frederik
2019-12-10 16:22 ` Harwath, Frederik
2019-12-11 8:38 ` [PATCH, committed] Fix PR92901: Change test expectation for C++ in OpenACC test clause-locations.c Harwath, Frederik
2020-11-03 8:17 ` [PATCH 0/2] Add tests to verify OpenACC clause locations Thomas Schwinge
2020-11-03 21:34 ` Thomas Schwinge
2019-12-10 14:23 ` [PATCH 1/2] Use clause locations in OpenACC nested reduction warnings Frederik Harwath
2019-12-10 14:23 ` [PATCH 2/2] Add tests to verify OpenACC clause locations Frederik Harwath
2020-11-03 8:26 ` [PATCH] Fix column information for omp_clauses in Fortran code Thomas Schwinge
2020-10-30 10:35 ` [Patch, Fortran] PR 92793 - fix column used for error diagnostic Thomas Schwinge
2020-10-30 10:47 ` Thomas Schwinge
2020-10-30 11:16 ` Tobias Burnus
2020-11-02 13:43 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde6fa5f-7261-78e9-1862-a45bf3729d52@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).