[Patch, microblaze]: Add -fstack-usage support

[Patch, microblaze]: Add -fstack-usage support

[David Holsgrove]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Changelog

2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>

 * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
   Add check for flag_stack_usage to handle -fstack-usage support

Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>


[-- Attachment #2: 0004-Patch-microblaze-Add-fstack-usage-support.patch --]
[-- Type: application/octet-stream, Size: 1160 bytes --]

From 6b656bd0ec9ff26a01ababdabcec019768cbb5ef Mon Sep 17 00:00:00 2001
From: David Holsgrove <david.holsgrove@xilinx.com>
Date: Thu, 27 Sep 2012 17:08:20 +1000
Subject: [PATCH] [Patch, microblaze]: Add -fstack-usage support

Changelog

2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>

 * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
   Add check for flag_stack_usage to enable -fstack-usage support

Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
---
 gcc/config/microblaze/microblaze.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gcc/config/microblaze/microblaze.c b/gcc/config/microblaze/microblaze.c
index 7418e49..4417289 100644
--- a/gcc/config/microblaze/microblaze.c
+++ b/gcc/config/microblaze/microblaze.c
@@ -2790,6 +2790,9 @@ microblaze_expand_prologue (void)
 
   fsiz = compute_frame_size (get_frame_size ());
 
+  if (flag_stack_usage)
+    current_function_static_stack_size = fsiz;
+
   /* If this function is a varargs function, store any registers that
      would normally hold arguments ($5 - $10) on the stack.  */
   if (((TYPE_ARG_TYPES (fntype) != 0
-- 
1.7.0.4

Re: [Patch, microblaze]: Add -fstack-usage support

[David Holsgrove]

Hi Michael,

On 18 March 2013 22:48, David Holsgrove <david.holsgrove@xilinx.com> wrote:
> Changelog
>
> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>
>  * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>    Add check for flag_stack_usage to handle -fstack-usage support
>
> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>

Patch remains the same, please apply when ready.

thanks,
David

Re: [Patch, microblaze]: Add -fstack-usage support

[Michael Eager]

On 03/18/13 05:48, David Holsgrove wrote:
> Changelog
>
> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>
>   * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>     Add check for flag_stack_usage to handle -fstack-usage support
>
> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>

Applied revision 201035.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [Patch, microblaze]: Add -fstack-usage support

[David Holsgrove]

On 19 July 2013 02:42, Michael Eager <eager@eagerm.com> wrote:
> On 03/18/13 05:48, David Holsgrove wrote:
>>
>> Changelog
>>
>> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>>
>>   * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>     Add check for flag_stack_usage to handle -fstack-usage support
>>
>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>
>
> Applied revision 201035.

Thanks Michael - did this get applied to trunk? I can't see the commit upstream.

regards,
David

>
> --
> Michael Eager    eager@eagercon.com
> 1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [Patch, microblaze]: Add -fstack-usage support

[Michael Eager]

On 07/18/13 16:25, David Holsgrove wrote:
> On 19 July 2013 02:42, Michael Eager <eager@eagerm.com> wrote:
>> On 03/18/13 05:48, David Holsgrove wrote:
>>>
>>> Changelog
>>>
>>> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>>>
>>>    * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>      Add check for flag_stack_usage to handle -fstack-usage support
>>>
>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>
>>
>> Applied revision 201035.
>
> Thanks Michael - did this get applied to trunk? I can't see the commit upstream.

Not sure what happened before, but it did not get committed.

Committed revision 201042.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [Patch, microblaze]: Add -fstack-usage support

[Eric Botcazou]

> > 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
> > 
> >  * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
> >    Add check for flag_stack_usage to handle -fstack-usage support
> > 
> > Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
> 
> Patch remains the same, please apply when ready.

The patch is incorrect, please adjust it to match the other architectures.

-- 
Eric Botcazou

Re: [Patch, microblaze]: Add -fstack-usage support

[Chung-Ju Wu]

On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>>>
>>>   * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>     Add check for flag_stack_usage to handle -fstack-usage support
>>>
>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>
>> Patch remains the same, please apply when ready.
>
> The patch is incorrect, please adjust it to match the other architectures.
>

Hi, David,

Specifically speaking, what Eric meant is to check
flag_stack_usage_info rather than flag_stack_usage
due to the changes after gcc-4.7.


Best regards,
jasonwucj

Re: [Patch, microblaze]: Add -fstack-usage support

[David Holsgrove]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

Hi Eric / Chung-Ju,

On 21 July 2013 01:33, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
> On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>>>
>>>> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>>>>
>>>>   * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>>     Add check for flag_stack_usage to handle -fstack-usage support
>>>>
>>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>>
>>>
>>> Patch remains the same, please apply when ready.
>>
>>
>> The patch is incorrect, please adjust it to match the other architectures.
>>
>
> Hi, David,
>
> Specifically speaking, what Eric meant is to check
> flag_stack_usage_info rather than flag_stack_usage
> due to the changes after gcc-4.7.
>

Ah, thanks for the catch - patch had been sitting in my tree for quite a while,
hadn't realised the variable name had changed on trunk.

Patch attached which adjusts microblaze's usage to align with other archs.

thanks,
David

>
> Best regards,
> jasonwucj
>

[-- Attachment #2: 0001-Patch-microblaze-Update-flag_stack_usage-variable-na.patch --]
[-- Type: application/octet-stream, Size: 1063 bytes --]

From 53c430e351142a66d32e7638183e00bb70a03c03 Mon Sep 17 00:00:00 2001
From: David Holsgrove <david.holsgrove@xilinx.com>
Date: Tue, 23 Jul 2013 09:18:47 +1000
Subject: [Patch, microblaze]: Update flag_stack_usage variable name

Changelog

2013-07-23  David Holsgrove <david.holsgrove@xilinx.com>

  *  gcc/config/microblaze/microblaze.c: Test flag_stack_usage_info
     variable instead of flag_stack_usage

Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
---
 gcc/config/microblaze/microblaze.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/microblaze/microblaze.c b/gcc/config/microblaze/microblaze.c
index c8a3f50..0ce4a9e 100644
--- a/gcc/config/microblaze/microblaze.c
+++ b/gcc/config/microblaze/microblaze.c
@@ -2918,7 +2918,7 @@ microblaze_expand_prologue (void)
 
   fsiz = compute_frame_size (get_frame_size ());
 
-  if (flag_stack_usage)
+  if (flag_stack_usage_info)
     current_function_static_stack_size = fsiz;
 
   /* If this function is a varargs function, store any registers that
-- 
1.7.9.5

Re: [Patch, microblaze]: Add -fstack-usage support

[Michael Eager]

On 07/22/13 22:50, David Holsgrove wrote:
> Hi Eric / Chung-Ju,
>
> On 21 July 2013 01:33, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
>> On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>>>>
>>>>> 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
>>>>>
>>>>>    * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>>>      Add check for flag_stack_usage to handle -fstack-usage support
>>>>>
>>>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>>>
>>>>
>>>> Patch remains the same, please apply when ready.
>>>
>>>
>>> The patch is incorrect, please adjust it to match the other architectures.
>>>
>>
>> Hi, David,
>>
>> Specifically speaking, what Eric meant is to check
>> flag_stack_usage_info rather than flag_stack_usage
>> due to the changes after gcc-4.7.
>>
>
> Ah, thanks for the catch - patch had been sitting in my tree for quite a while,
> hadn't realised the variable name had changed on trunk.
>
> Patch attached which adjusts microblaze's usage to align with other archs.

Committed revision 201186.

Please send an updated ChangeLog when it is different from the
original.

ChangeLog:

2013-07-23  David Holsgrove <david.holsgrove@xilinx.com>

	* config/microblaze/microblaze.c (microblaze_expand_prologue):
	Rename flag_stack_usage to flag_stack_usage_info.



-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077