From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id E971B385AC22 for ; Fri, 1 Dec 2023 09:13:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E971B385AC22 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E971B385AC22 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701422007; cv=none; b=k4ZFafBGXvze7kjdZiEOnBcZkCIJKLIFk+1wf2/0ahYn35nmW6MGURLVycFHxJIe49nc6+83AWsRpdRE7cZWyv0AudvNom4JLudd+oAvoOGcpFX1I6yX2DfnHo8s3In/B1XIfudMsapaKPGjdNla6Yov1NyYVenFCJ5zGn4NxTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701422007; c=relaxed/simple; bh=9DQFKlFDuKiOaw9SiN+Q1ClTCPx9nFsDmguwpNsC2Xs=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=vKYcb6hYf5R3H6c2uvsyEItYmIkxcvUvEgSCCvfmurqoLHueD5gGkxTIxz1XvQ7nJ0sfsIDRyOXmxkIfzk6v306zX2RBQjc/akQpJw62rroxagIUfbOPYJefbK4YFJJTslZ+Js0LoHzNIwgyDsUq2FMsjQaPgOZ/n2qS6cSPiwM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B198nxX019736; Fri, 1 Dec 2023 09:13:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=lXgXA8beXi9MJeLvzuOW5oDpDE4QLB4jxeH6kLseTW0=; b=S/vlk0lAfZyIuks0giUZ/h5ZNKJsMmIwsKnbdsgTnDnu44mgdxZBQjXV8zruedB8V4nM jyrJCz0tS8n67qj4RO5Z3KwXgRG8C+p1eSxuuEnqBwYMiCSxD87O/VOr3d5IrNQtGch9 hPAIyihYAIjsn0ClISbG2rT7gyU6UwXLAwQB3YiBPmy/6exu69TNXbQln6lrsjOUquQA y/+xOk5ygEV24fqY2R9k8mJGLSzx3phTle3XQul5tVCLmILs7HOBqsxOXYZM7EDp8o5p M0rqnKoSkF8wYeWx/4ViuZLMUyj4HNLAyKK+OxDGViYc2LVw9XYVdZzodAHW1raMkGLy vg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uqbx79ccm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 09:13:24 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B19BiIN031387; Fri, 1 Dec 2023 09:13:23 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uqbx79ccc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 09:13:23 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3B194R2s031276; Fri, 1 Dec 2023 09:13:23 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ukv8p428p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 09:13:23 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3B19DMoS9896478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2023 09:13:22 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 17C0B5803F; Fri, 1 Dec 2023 09:13:22 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1ADF95805A; Fri, 1 Dec 2023 09:13:19 +0000 (GMT) Received: from [9.43.32.20] (unknown [9.43.32.20]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 1 Dec 2023 09:13:18 +0000 (GMT) Message-ID: Date: Fri, 1 Dec 2023 14:43:17 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] rs6000: Add new pass for replacement of contiguous addresses vector load lxv with lxvp Content-Language: en-US To: "Kewen.Lin" , Michael Meissner Cc: gcc-patches , David Edelsohn , Segher Boessenkool , Peter Bergner References: <629b1028-7f4d-aca1-e6d4-c9fbe9e0e2dc@linux.ibm.com> From: Ajit Agarwal In-Reply-To: <629b1028-7f4d-aca1-e6d4-c9fbe9e0e2dc@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ii7_nzAHET0WDzWHvs3hubNz4Lb3mzXR X-Proofpoint-GUID: ozNWMD-9HxUq54Hb7Xg1ZfcP8xHtrRyS Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-01_06,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 clxscore=1015 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312010060 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/11/23 3:14 pm, Kewen.Lin wrote: > on 2023/11/28 15:05, Michael Meissner wrote: >> I tried using this patch to compare with the vector size attribute patch I >> posted. I could not build it as a cross compiler on my x86_64 because the >> assembler gives the following error: >> >> Error: operand out of domain (11 is not a multiple of 2) for >> std_stacktrace-elf.o. If you look at the assembler, it has combined a lxvp 11 >> and lxvp 12 into: >> >> lxvp 11,0(9) >> >> The powerpc architecture requires that registers that are loaded with load >> vector pair and stored with store vector point instructions only load/store >> even/odd register pairs, and not odd/even pairs. Unfortunately, it will mean >> that this optimization will match less often. >> > > Yes, the current implementation need some refinements, as comments in [1]: > >> Besides, it seems a bad idea to put this pass after reload? as register allocation >> finishes, this pairing has to be restricted by the reg No. (I didn't see any >> checking on the reg No. relationship for paring btw.) >> >> Looking forward to the comments from Segher/David/Peter/Mike etc. > > I wonder if we should consider running such pass before reload instead. Adding before reload pass deletes one of the lxv and replaced with lxvp. This fails in reload pass while freeing reg_eqivs as ira populates them and then vecload pass deletes some of insns and while freeing in reload pass as insn is already deleted in vecload pass reload pass segfaults. Moving vecload pass before ira will not make register pairs with lxvp and in ira and that will be a problem. Making after reload pass is the only solution I see as ira and reload pass makes register pairs and vecload pass will be easier with generation of lxvp. Thanks & Regards Ajit > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638070.html > > BR, > Kewen