From: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
To: Richard Ball <Richard.Ball@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] arm: Zero/Sign extends for CMSE security
Date: Fri, 26 Apr 2024 10:39:00 +0200 [thread overview]
Message-ID: <be27abe4-d4b7-4eee-a93a-dc747c3dde1d@foss.st.com> (raw)
In-Reply-To: <DB9PR08MB6957D114A42E47184EBEE28781172@DB9PR08MB6957.eurprd08.prod.outlook.com>
Hi,
On 2024-04-25 16:25, Richard Ball wrote:
> Hi Torbjorn,
>
> Thanks very much for the comments.
> I think given that the code that handles this, is within a
> FOREACH_FUNCTION_ARGS loop.
> It seems a fairly safe assumption that if the code works for one that it
> will work for all.
> To go back and add extra tests to me seems a little overkill.
For verifying that the implementation does the right thing now, no, but
for verifying against future regressions, then yes.
So, from a regression point of view, I think it makes sense to have the
check that more than the first argument is managed properly.
Kind regards,
Torbjörn
next prev parent reply other threads:[~2024-04-26 8:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 15:55 Richard Ball
2024-04-25 10:01 ` Richard Earnshaw (lists)
2024-04-25 11:47 ` Torbjorn SVENSSON
2024-04-25 14:25 ` Richard Ball
2024-04-26 8:39 ` Torbjorn SVENSSON [this message]
2024-04-26 9:19 ` Richard Earnshaw (lists)
2024-04-27 14:13 ` [PATCH] testsuite: Verify r0-r3 are extended with CMSE Torbjörn SVENSSON
2024-04-30 15:11 ` Richard Earnshaw (lists)
2024-04-30 15:37 ` Torbjorn SVENSSON
2024-04-30 16:50 ` Richard Earnshaw (lists)
2024-05-02 10:50 ` [PATCH v2] " Torbjörn SVENSSON
2024-05-06 11:50 ` Torbjorn SVENSSON
2024-05-14 11:01 ` [PING] " Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be27abe4-d4b7-4eee-a93a-dc747c3dde1d@foss.st.com \
--to=torbjorn.svensson@foss.st.com \
--cc=Richard.Ball@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).