public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Martin Sebor <msebor@gmail.com>,
	Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] add calls.c to GTFILES in Makefile.in
Date: Tue, 14 Mar 2017 22:17:00 -0000	[thread overview]
Message-ID: <be2ce309-b132-4e08-d9c4-04616604946a@redhat.com> (raw)
In-Reply-To: <26c31f25-7cdb-5912-6954-83dcd8683ce6@gmail.com>

On 03/07/2017 06:03 PM, Martin Sebor wrote:
> In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter
> encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source
> file that implements the warning accessing a global tree without
> having included the file in GTFILES make variable.  (Thanks again
> to David Malcolm who helped me root cause this bug.)
>
> The attached patch fixes this by adding calls.c to the variable and
> by including the requisite generated header, gt-calls.h, at the end
> of the source.
>
> Martin
>
> gcc-79936.diff
>
>
> PR c/79936 - [7 Regression] ICE with -Walloc-size-larger-than=32767
>
> gcc/ChangeLog:
>
> 	PR c/79936
> 	* Makefile.in (GTFILES): Add calls.c.
> 	* calls.c (must_pass_in_stack_var_size_or_pad): Include "gt-calls.h".
I fixed the ChangeLog entry for calls.c and installed this.

Thanks,
jeff

      parent reply	other threads:[~2017-03-14 22:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  1:04 Martin Sebor
2017-03-14  0:37 ` [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936) Martin Sebor
2017-03-14  9:01   ` Richard Biener
2017-03-14 15:52     ` Jeff Law
2017-03-17 11:46       ` Richard Biener
2017-03-14 22:17 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be2ce309-b132-4e08-d9c4-04616604946a@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=msebor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).