public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Andrew Stubbs <ams@codesourcery.com>
Cc: Tobias Burnus <tobias@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated
Date: Sun, 22 Oct 2023 14:24:23 +0200 (CEST)	[thread overview]
Message-ID: <be7e8e16-132c-7613-2f30-c5c3e30dd178@pfeifer.com> (raw)
In-Reply-To: <b3e2536e-f20e-4760-96d4-bdb8cf072dd2@codesourcery.com>

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi Andrew,

On Fri, 20 Oct 2023, Andrew Stubbs wrote:
>>  Additionally, I wonder whether "Fiji" should be changed to "Fiji
>> (gfx803)" in the first line and whether the  "," should be removed in
>> "The ... configuration ... , and no longer includes".
> Fair enough, how's this version? (I like the comma, even if it is optional.)

it's definitely fine. I do have a recommendation and a question, though 
feel free to go about them as you prefer.

+  <li>The default device architecture is now <code>gfx900</code> (Vega).</li>

How about starting with this as the first sub-item, as a "positive", 
then follow with the deprecation?

+<ul>
+  <li>
+    The Fiji (gfx803) device support is now deprecated and will be removed from

Could this be "Fiji (gfx803) device support" without the article?

Gerald

  parent reply	other threads:[~2023-10-22 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  9:49 Andrew Stubbs
2023-10-19 10:07 ` Tobias Burnus
2023-10-20 12:58   ` Andrew Stubbs
2023-10-20 13:09     ` Tobias Burnus
2023-10-22 12:24     ` Gerald Pfeifer [this message]
2023-10-27 12:54       ` Andrew Stubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be7e8e16-132c-7613-2f30-c5c3e30dd178@pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=ams@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).