From: "Kewen.Lin" <linkw@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Peter Bergner <bergner@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: PING^1 [PATCH] rs6000: Adjust mov optabs for opaque modes [PR103353]
Date: Tue, 15 Mar 2022 19:36:37 +0800 [thread overview]
Message-ID: <beb97d6c-90c7-21ca-94d0-17ceb8ae3b83@linux.ibm.com> (raw)
In-Reply-To: <26dce79a-be26-95b0-c14d-51852811969a@linux.ibm.com>
Hi,
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591150.html
BR,
Kewen
on 2022/3/3 4:38 PM, Kewen.Lin via Gcc-patches wrote:
> Hi,
>
> As PR103353 shows, we may want to continue to expand a MMA built-in
> function like a normal function, even if we have already emitted
> error messages about some missing required conditions. As shown in
> that PR, without one explicit mov optab on OOmode provided, it would
> call emit_move_insn recursively.
>
> So this patch is to allow the mov pattern to be generated when we are
> expanding to RTL and have seen errors even without MMA supported, it's
> expected that the generated pattern would not cause further ICEs as the
> compilation would stop soon after expanding.
>
> Bootstrapped and regtested on powerpc64-linux-gnu P8 and
> powerpc64le-linux-gnu P9 and P10.
>
> Is it ok for trunk?
>
> BR,
> Kewen
> ------
>
> PR target/103353
>
> gcc/ChangeLog:
>
> * config/rs6000/mma.md (define_expand movoo): Move TARGET_MMA condition
> check to preparation statements and add handlings for !TARGET_MMA.
> (define_expand movxo): Likewise.
next prev parent reply other threads:[~2022-03-15 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 8:38 Kewen.Lin
2022-03-15 11:36 ` Kewen.Lin [this message]
2022-04-01 20:50 ` will schmidt
2022-04-01 21:52 ` Peter Bergner
2022-04-07 9:42 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb97d6c-90c7-21ca-94d0-17ceb8ae3b83@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).