From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Jan Hubicka <hubicka@ucw.cz>, Jakub Jelinek <jakub@redhat.com>,
Jeff Law <law@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>,
Michael Matz <matz@suse.de>
Subject: Re: [PATCH] Properly detect working jobserver in gcc driver.
Date: Fri, 09 Aug 2019 13:56:00 -0000 [thread overview]
Message-ID: <bed491c7-66e3-f928-fdc2-ac8c730edcad@suse.cz> (raw)
In-Reply-To: <142656c6-3e7d-0e45-f014-3cb4b1fda4f1@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
On 8/9/19 2:38 PM, Martin Liška wrote:
> On 8/9/19 10:19 AM, Richard Biener wrote:
>> OK with that. I still think that making -flto use a jobserver if detected
>> (but _not_ use the number of CPU cores by default) makes
>> sense as an independent change.
>
> In order to address that, I'm suggesting following patch that I've been
> testing.
>
> Martin
>
Hm, I take back the config changes.
Martin
[-- Attachment #2: 0001-Automatically-detect-GNU-jobserver-with-flto.patch --]
[-- Type: text/x-patch, Size: 1600 bytes --]
From 1f9c9f74a84ec3ca930bbc9525ef2185200e0ce8 Mon Sep 17 00:00:00 2001
From: Martin Liska <mliska@suse.cz>
Date: Fri, 9 Aug 2019 14:03:11 +0200
Subject: [PATCH] Automatically detect GNU jobserver with -flto.
gcc/ChangeLog:
2019-08-09 Martin Liska <mliska@suse.cz>
* doc/invoke.texi: Document automatic detection of jobserver.
* lto-wrapper.c (run_gcc): Detect jobserver always.
---
gcc/doc/invoke.texi | 3 ++-
gcc/lto-wrapper.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 5b6b824bdd3..0000d358e48 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10422,7 +10422,8 @@ job server mode to determine the number of parallel jobs. This
is useful when the Makefile calling GCC is already executing in parallel.
You must prepend a @samp{+} to the command recipe in the parent Makefile
for this to work. This option likely only works if @env{MAKE} is
-GNU make.
+GNU make. Even without the option value, GCC tries to automatically
+detect a running GNU make's job server.
Use @option{-flto=auto} to use GNU make's job server, if available,
or otherwise fall back to autodetection of the number of CPU threads
diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c
index 84f59cf1a1f..339c379d972 100644
--- a/gcc/lto-wrapper.c
+++ b/gcc/lto-wrapper.c
@@ -1427,7 +1427,7 @@ run_gcc (unsigned argc, char *argv[])
auto_parallel = 0;
parallel = 0;
}
- else if (!jobserver && auto_parallel)
+ else if (!jobserver)
jobserver = jobserver_active_p ();
if (linker_output)
--
2.22.0
next prev parent reply other threads:[~2019-08-09 13:05 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 8:55 [PATCH] Come up with -flto=auto option Martin Liška
2019-07-23 9:29 ` Jan Hubicka
2019-07-23 10:34 ` [PATCH] Deduce automatically number of cores for -flto option Martin Liška
2019-07-24 15:47 ` Jeff Law
2019-07-29 13:37 ` Martin Liška
2019-07-30 13:47 ` Martin Liška
2019-07-31 1:23 ` Jakub Jelinek
2019-07-31 7:24 ` Martin Liška
2019-07-31 7:40 ` Jakub Jelinek
2019-07-31 7:49 ` Jan Hubicka
2019-07-31 7:50 ` Martin Liška
2019-07-31 7:54 ` Martin Liška
2019-07-31 8:08 ` Jakub Jelinek
2019-07-31 8:21 ` Jan Hubicka
2019-07-31 8:37 ` Martin Liška
2019-07-31 9:12 ` Jakub Jelinek
2019-07-31 9:15 ` Jan Hubicka
2019-07-31 9:17 ` Jakub Jelinek
2019-07-31 9:22 ` Jan Hubicka
2019-07-31 10:02 ` Martin Liška
2019-07-31 12:02 ` Jan Hubicka
2019-07-31 15:42 ` Martin Liška
2019-08-01 13:19 ` Jakub Jelinek
2019-08-01 14:34 ` [PATCH] Properly detect working jobserver in gcc driver Martin Liška
2019-08-01 14:41 ` Jakub Jelinek
2019-08-02 6:30 ` Martin Liška
2019-08-02 7:45 ` Jakub Jelinek
2019-08-02 8:47 ` Martin Liška
2019-08-02 8:50 ` Jakub Jelinek
2019-08-02 9:04 ` Richard Biener
2019-08-02 9:08 ` Jan Hubicka
2019-08-02 9:15 ` Jan Hubicka
2019-08-02 9:19 ` Martin Liška
2019-08-02 9:55 ` Richard Biener
2019-08-05 6:41 ` Martin Liška
2019-08-09 8:14 ` Martin Liška
2019-08-09 8:22 ` Richard Biener
2019-08-09 12:51 ` Martin Liška
2019-08-09 13:56 ` Martin Liška [this message]
2019-08-12 15:18 ` Jeff Law
2019-07-23 13:13 ` [PATCH] Come up with -flto=auto option Jeff Law
2019-07-23 13:22 ` Richard Biener
2019-07-23 13:57 ` Michael Matz
2019-07-23 14:00 ` Jeff Law
2019-07-23 14:27 ` Martin Liška
2019-07-23 22:56 ` Jeff Law
2019-07-24 6:59 ` Martin Liška
2019-07-24 15:16 ` Jeff Law
2019-07-23 22:32 ` Allan Sandfeld Jensen
2019-07-24 6:47 ` Martin Liška
2019-07-24 7:12 ` Allan Sandfeld Jensen
2019-07-24 7:15 ` Martin Liška
2019-07-24 11:09 ` Nathan Sidwell
2019-07-24 15:46 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bed491c7-66e3-f928-fdc2-ac8c730edcad@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
--cc=matz@suse.de \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).