From: David Malcolm <dmalcolm@redhat.com>
To: "Martin Liška" <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/7] jit,docs: replace c:type:`int_type` with :expr:`int_type`
Date: Tue, 26 Jul 2022 11:42:24 -0400 [thread overview]
Message-ID: <beddabd8a25ccf0a16a190f527672934f8450008.camel@redhat.com> (raw)
In-Reply-To: <8d3698c5-a432-e28e-3c56-3a070e63a7f7@suse.cz>
On Tue, 2022-07-26 at 06:48 +0200, Martin Liška wrote:
> On 7/26/22 00:37, David Malcolm wrote:
> > On Mon, 2022-07-25 at 11:03 +0200, Martin Liska wrote:
> > > Use expression that work fine for basic type.
> >
> > What's the motivation for this change? Surely the things being
> > marked
> > up are types, rather than expressions?
>
> Problem is that one can't reference a type that is not defined by a
> :type: directive,
> that's why I'm using :expr:
>
> Fixes the following Sphinx warnings:
>
> /home/marxin/Programming/gcc/gcc/jit/docs/topics/expressions.rst:70:
> WARNING: Unparseable C cross-reference: 'long'
> Invalid C declaration: Expected identifier in nested name, got
> keyword: long [error at 4]
> long
> ----^
Fair enough, thanks. LGTM.
Dave
next prev parent reply other threads:[~2022-07-26 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 13:13 [PATCH 0/7] jit,docs: remove warnings and modernize the docs Martin Liska
2022-07-25 8:52 ` [PATCH 1/7] jit,docs: use enum directive for enumeral types Martin Liska
2022-07-25 22:35 ` David Malcolm
2022-07-26 4:47 ` Martin Liška
2022-07-25 9:03 ` [PATCH 2/7] jit, docs: replace c:type:`int_type` with :expr:`int_type` Martin Liska
2022-07-25 22:37 ` [PATCH 2/7] jit,docs: " David Malcolm
2022-07-26 4:48 ` Martin Liška
2022-07-26 15:42 ` David Malcolm [this message]
2022-07-25 9:15 ` [PATCH 3/7] jit,docs: various fixes Martin Liska
2022-07-25 22:39 ` David Malcolm
2022-07-25 9:51 ` [PATCH 4/7] jit,docs: compact function declarations Martin Liska
2022-07-25 22:39 ` David Malcolm
2022-07-25 10:35 ` [PATCH 5/7] jit,docs: use list-table instead of fixed table Martin Liska
2022-07-25 22:40 ` David Malcolm
2022-07-25 12:39 ` [PATCH 6/7] jit,docs: use :expr:`type *` for pointers to a type Martin Liska
2022-07-25 22:41 ` David Malcolm
2022-07-26 4:50 ` Martin Liška
2022-07-26 15:43 ` David Malcolm
2022-07-26 4:55 ` [PATCH 7/7] jit,docs: remove :ref:`modindex` Martin Liška
2022-07-26 15:44 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beddabd8a25ccf0a16a190f527672934f8450008.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).