From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id CF996385843E for ; Fri, 14 Jul 2023 02:50:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF996385843E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-403af7dfa3aso11510371cf.0 for ; Thu, 13 Jul 2023 19:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689303040; x=1691895040; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=okqYcngX0oorw63ZuzlVzZwUmpfuef+2tdBufbHhijU=; b=p82BzJemSnmwHGO4oRTKA1M5SVtN8htgP9wTNkpK1+jAU8SrTiKJSxxhZiuhMVJ3kj ordrbWiPPROY3RlG1MpL9LOFwt7ccCLmyGjant4fZkZTb4a6AQAVZEl4kuV66tYmlKeF XaGauH/Gw0pn0e9fzHaJWcE0nWcrfrnAzo2qYQN4rBFeTDGFytoeIopCG0cgsH1PK7Aa uwQzDwV6uVhL47Bvciif2fq8PkdWzfPE7JRSbjY863HBGBBo211Ahatp6j3FiTcSs1hE aOPmC6MIhIH0uzR7W93UBxNFWB37c/3J3+V4qHkkYtk4NmCtI+ySGyzIVZ0c/KmGTSIm 3wkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689303040; x=1691895040; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=okqYcngX0oorw63ZuzlVzZwUmpfuef+2tdBufbHhijU=; b=C1wBi1zvEubgywMSy9wxlianHblzXoHiPbcQtkfl62rwXK+PXZw34myJKq7UR1Ki4P nEEI0DHjXrflkgCV0id37TgVK0XodDASd4i3NM68edB2WO0XVVxOPDSMBTtRIi58jc6P U/esA9F4NjAddu1TnNkn1T13begdWAdUxrLwI2keDgcFfvOWgDxGNiES+JlqjJYzM6Uf YMkJkewiby1bHNj458lYnhP8+xAUwTIMdS+v54s3TGUv6xWE/brvEJhAdTiLK+UmDE0j WNJR8mT3dO9nUHV4QMYal67s6vZGca+MwHirnf5IfkWm1/EGQg8q9xjz+e+BIYseNgpc IM9Q== X-Gm-Message-State: ABy/qLZmIcZa0TNvCoj0YrezerDVn9HGm+e0USjfTRCdeB9HhmoqCaJQ sVYNOOs43P6Yq6c1fgGidfw= X-Google-Smtp-Source: APBJJlEJ8Zqq/nbpL2AjUTmJTOUYt6HFSDyzHCPFHei5w67l/213NUBWJtEuEghMcZEE8p7zr65O4w== X-Received: by 2002:a05:622a:34d:b0:403:ac9c:abff with SMTP id r13-20020a05622a034d00b00403ac9cabffmr4462197qtw.31.1689303040152; Thu, 13 Jul 2023 19:50:40 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id w18-20020a170902d71200b001b02bd00c61sm6602659ply.237.2023.07.13.19.50.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 19:50:39 -0700 (PDT) Message-ID: Date: Thu, 13 Jul 2023 20:50:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] RISC-V: Remove the redundant expressions in the and3. Content-Language: en-US To: Palmer Dabbelt , gcc-patches@gcc.gnu.org Cc: lidie@eswincomputing.com, jeffeyalaw@gmail.com References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/13/23 20:44, Palmer Dabbelt wrote: > On Thu, 13 Jul 2023 19:41:08 PDT (-0700), gcc-patches@gcc.gnu.org wrote: >> Expanding without DONE or FAIL will leave the pattern as well, so this >> patch is fine IMO, so this patch LGTM, but anyway I will test this and >> commit if passed :) > > Ah, thanks, I guess I didn't know that.  This is probably fine then, but > we might have some code floating around we could toss... Yea, if you fall off the end the original pattern stays in place. It's always been that way. And yes, we may have a bit of redundant code and more importantly useless RTL generation. jeff